Simplify logic for setting __aarch64_have_lse_atomics#4080
Merged
Conversation
When using a non-glibc loader (e.g. musl), __aarch64_ldadd4_relax will not necessarily be present, but the loader could still be using other outlined atomic functions, so the search for __aarch64_ldadd4_relax would not necessarily succeed. Therefore, remove the logic for disassembling __aarch64_ldadd4_relax, and replace it with code that sets __aarch64_have_lse_atomics directly. This logic was considered necessary because __aarch64_have_lse_atomics isn't exported. However, __aarch64_ldadd4_relax isn't exported either. So either way, the symbol should be findable via .symtab if it is present. It's possible that this wouldn't have worked before because of the bug fixed by rr-debugger#4035.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a non-glibc loader (e.g. musl), __aarch64_ldadd4_relax will not necessarily be present, but the loader could still be using other outlined atomic functions, so the search for __aarch64_ldadd4_relax would not necessarily succeed. Therefore, remove the logic for disassembling __aarch64_ldadd4_relax, and replace it with code that sets __aarch64_have_lse_atomics directly.
This logic was considered necessary because __aarch64_have_lse_atomics isn't exported. However, __aarch64_ldadd4_relax isn't exported either. So either way, the symbol should be findable via .symtab if it is present.
It's possible that this wouldn't have worked before because of the bug fixed by #4035.