Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 86.86% 86.84% -0.03%
==========================================
Files 40 40
Lines 2856 2881 +25
==========================================
+ Hits 2481 2502 +21
- Misses 375 379 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Overall, this looks good to me. I still want to test it out a bit more before fully approving the change. Just wanted to confirm two things first:
|
Valid concerns. I agree we should confirm before merging. |
JBGreisman
left a comment
There was a problem hiding this comment.
looks fine to me -- I think we should just confirm it behaves with phenix / aimless before merging.
This attempts to address #344 to enable batching with
dataset.write_mtz. I could use some eyes on this control flow.This changes the signature for
rs.DataSet.write_mtzaddingbatch=Trueandbatch_key=Noneoptions.write_mtzwill generate a naive set of batches in the header ifbatchis truthy.batch_keywill be inferred and is only explicitly needed of there are multiple columns with BATCH dtype.batch=Falseandbatch_key is not Nonewill raise a ValueError.