Configure ORA_TZFILE to match Oracle 11g server in CI

Both 11g workflows (test_11g.yml, test_11g_ojdbc11.yml) set
DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH=true to skip tests that
failed because Oracle 11g XE ships timezone file DSTv14 while Instant
Client 21.15 embeds v35, producing ORA-01805 on DATE/TIMESTAMP fetches.
The same flag was later reused to skip two JDBC network-encryption
tests in connection_spec.rb because 11g XE lacks native network
encryption -- an unrelated limitation.

Adopt the approach from rsim/ruby-plsql#239: copy the v14 timezone
data files out of the running gvenzl/oracle-xe:11 container into the
Instant Client's oracore/zoneinfo directory and point the client at
them via ORA_TZFILE. Set ORA_TZFILE to the basename (timezlrg_14.dat)
so Oracle Instant Client resolves it relative to
ORACLE_HOME/oracore/zoneinfo/; the absolute-path form produces
ORA-01804 in sqlplus. With that in place the ORA-01805 error
disappears and the opaque DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH
flag can be removed everywhere.

The two network-encryption skips are rewired onto DATABASE_VERSION ==
'11.2.0.2', which is the honest condition -- the limitation is a
property of the 11g server, not of any server/client version mismatch.
Also drop the stale ORACLE_HOME == '/usr/lib/oracle/21/client64'
fallback in timestamp_spec.rb; current workflows use
/opt/oracle/instantclient_21_15, so it never matched.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: yahonda

.github/workflows/test_11g.yml

@@ -36,7 +36,6 @@ jobs:
       DATABASE_HOST: localhost
       DATABASE_PORT: 1521
       DATABASE_VERSION: 11.2.0.2
-      DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH: true
 
     services:
       oracle:
@@ -76,6 +75,19 @@ jobs:
       - name: Install JDBC Driver
         run: |
           wget -q https://download.oracle.com/otn-pub/otn_software/jdbc/23261/ojdbc17.jar -O ./lib/ojdbc17.jar
+      - name: Configure ORA_TZFILE to match Oracle 11g server
+        run: |
+          # Oracle 11g XE uses timezone file v14; Instant Client 21.15 embeds
+          # v35. This mismatch causes ORA-01805 when fetching DATE/TIMESTAMP
+          # values. Copy the v14 files from the 11g container and point the
+          # Instant Client at them via ORA_TZFILE.
+          ORACLE_CONTAINER=$(docker ps --filter "ancestor=gvenzl/oracle-xe:11" -q)
+          sudo mkdir -p /opt/oracle/instantclient_21_15/oracore/zoneinfo
+          docker cp "$ORACLE_CONTAINER":/u01/app/oracle/product/11.2.0/xe/oracore/zoneinfo/timezlrg_14.dat /tmp/timezlrg_14.dat
+          docker cp "$ORACLE_CONTAINER":/u01/app/oracle/product/11.2.0/xe/oracore/zoneinfo/timezone_14.dat /tmp/timezone_14.dat
+          sudo mv /tmp/timezlrg_14.dat /opt/oracle/instantclient_21_15/oracore/zoneinfo/
+          sudo mv /tmp/timezone_14.dat /opt/oracle/instantclient_21_15/oracore/zoneinfo/
+          echo "ORA_TZFILE=timezlrg_14.dat" >> $GITHUB_ENV
       - name: Create database user
         run: |
           ./ci/setup_accounts.sh

.github/workflows/test_11g_ojdbc11.yml

@@ -32,7 +32,6 @@ jobs:
       DATABASE_HOST: localhost
       DATABASE_PORT: 1521
       DATABASE_VERSION: 11.2.0.2
-      DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH: true
 
     services:
       oracle:
@@ -71,6 +70,19 @@ jobs:
       - name: Install JDBC Driver
         run: |
           wget -q https://download.oracle.com/otn-pub/otn_software/jdbc/23261/ojdbc11.jar -O ./lib/ojdbc11.jar
+      - name: Configure ORA_TZFILE to match Oracle 11g server
+        run: |
+          # Oracle 11g XE uses timezone file v14; Instant Client 21.15 embeds
+          # v35. This mismatch causes ORA-01805 when fetching DATE/TIMESTAMP
+          # values. Copy the v14 files from the 11g container and point the
+          # Instant Client at them via ORA_TZFILE.
+          ORACLE_CONTAINER=$(docker ps --filter "ancestor=gvenzl/oracle-xe:11" -q)
+          sudo mkdir -p /opt/oracle/instantclient_21_15/oracore/zoneinfo
+          docker cp "$ORACLE_CONTAINER":/u01/app/oracle/product/11.2.0/xe/oracore/zoneinfo/timezlrg_14.dat /tmp/timezlrg_14.dat
+          docker cp "$ORACLE_CONTAINER":/u01/app/oracle/product/11.2.0/xe/oracore/zoneinfo/timezone_14.dat /tmp/timezone_14.dat
+          sudo mv /tmp/timezlrg_14.dat /opt/oracle/instantclient_21_15/oracore/zoneinfo/
+          sudo mv /tmp/timezone_14.dat /opt/oracle/instantclient_21_15/oracore/zoneinfo/
+          echo "ORA_TZFILE=timezlrg_14.dat" >> $GITHUB_ENV
       - name: Create database user
         run: |
           ./ci/setup_accounts.sh

spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb

@@ -65,7 +65,7 @@
   end
 
   it "should not encrypt JDBC network connection" do
-    skip "Oracle 11g XE does not support native network encryption" if ENV["DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH"] == "true"
+    skip "Oracle 11g XE does not support native network encryption" if ENV["DATABASE_VERSION"] == "11.2.0.2"
     if ORACLE_ENHANCED_CONNECTION == :jdbc
       ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS.merge(jdbc_connect_properties: { "oracle.net.encryption_client" => "REJECTED" }))
       conn = ActiveRecord::Base.connection.send(:_connection)
@@ -74,7 +74,7 @@
   end
 
   it "should encrypt JDBC network connection" do
-    skip "Oracle 11g XE does not support native network encryption" if ENV["DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH"] == "true"
+    skip "Oracle 11g XE does not support native network encryption" if ENV["DATABASE_VERSION"] == "11.2.0.2"
     if ORACLE_ENHANCED_CONNECTION == :jdbc
       ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS.merge(jdbc_connect_properties: { "oracle.net.encryption_client" => "REQUESTED" }))
       conn = ActiveRecord::Base.connection.send(:_connection)

spec/active_record/oracle_enhanced/type/timestamp_spec.rb

@@ -4,10 +4,6 @@
   include SchemaSpecHelper
 
   before(:all) do
-    skip if ENV["DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH"] == "true"
-    if ENV["DATABASE_VERSION"] == "11.2.0.2" && ENV["ORACLE_HOME"] == "/usr/lib/oracle/21/client64"
-      skip
-    end
     ActiveRecord.default_timezone = :local
     ActiveRecord::Base.establish_connection(CONNECTION_WITH_TIMEZONE_PARAMS)
     @conn = ActiveRecord::Base.connection