Skip to content

Commit 0d77bbf

Browse files
yahondaclaude
andcommitted
Avoid downloading Oracle JDBC driver where unused
The `wget ojdbc17.jar` step had become a hard dependency on Oracle's download endpoint for matrix entries that never load the jar: - `test.yml` and `test_11g.yml`: gate the download with `if: startsWith(matrix.ruby, 'jruby')` so MRI rubies skip it. - `test_gemfiles.yml`: drop the step entirely; the matrix is MRI-only. Also add `jruby-10.0.5.0` (with Oracle JDK 21 via `actions/setup-java`) to the `test_11g.yml` matrix so the download that remains is exercised against Oracle 11g XE. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent ced3fe4 commit 0d77bbf

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ jobs:
6868
sudo unzip -qo instantclient-sqlplus-linux.x64-23.26.1.0.0.zip -d /opt/oracle/
6969
echo "/opt/oracle/instantclient_23_26" >> $GITHUB_PATH
7070
- name: Install JDBC Driver
71+
if: startsWith(matrix.ruby, 'jruby')
7172
run: |
7273
wget -q https://download.oracle.com/otn-pub/otn_software/jdbc/23261/ojdbc17.jar -O ./lib/ojdbc17.jar
7374
- name: Create database user

.github/workflows/test_11g.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ jobs:
1919
'4.0',
2020
'3.4',
2121
'3.3',
22-
'3.2'
22+
'3.2',
23+
'jruby-10.0.5.0',
2324
]
2425
env:
2526
ORACLE_HOME: /opt/oracle/instantclient_21_15
@@ -46,6 +47,12 @@ jobs:
4647
4748
steps:
4849
- uses: actions/checkout@v6
50+
- name: Set up Java
51+
if: startsWith(matrix.ruby, 'jruby')
52+
uses: actions/setup-java@v4
53+
with:
54+
distribution: oracle
55+
java-version: '21'
4956
- name: Set up Ruby
5057
uses: ruby/setup-ruby@v1
5158
with:
@@ -66,6 +73,7 @@ jobs:
6673
sudo unzip -qo instantclient-sdk-linux.x64-21.15.0.0.0dbru.zip -d /opt/oracle
6774
echo "/opt/oracle/instantclient_21_15" >> $GITHUB_PATH
6875
- name: Install JDBC Driver
76+
if: startsWith(matrix.ruby, 'jruby')
6977
run: |
7078
wget -q https://download.oracle.com/otn-pub/otn_software/jdbc/23261/ojdbc17.jar -O ./lib/ojdbc17.jar
7179
- name: Configure ORA_TZFILE to match Oracle 11g server

.github/workflows/test_gemfiles.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,6 @@ jobs:
8282
sudo unzip -qo instantclient-sdk-linux.x64-23.26.1.0.0.zip -d /opt/oracle/
8383
sudo unzip -qo instantclient-sqlplus-linux.x64-23.26.1.0.0.zip -d /opt/oracle/
8484
echo "/opt/oracle/instantclient_23_26" >> $GITHUB_PATH
85-
- name: Install JDBC Driver
86-
run: |
87-
wget -q https://download.oracle.com/otn-pub/otn_software/jdbc/23261/ojdbc17.jar -O ./lib/ojdbc17.jar
8885
- name: Create database user
8986
run: |
9087
./ci/setup_accounts.sh

0 commit comments

Comments
 (0)