Skip to content

Commit 5230d25

Browse files
yahondaclaude
andcommitted
Fix frozen string literal warnings
Use +\"\" for string literals that are mutated with << operator. This prepares for Ruby's future frozen string literal default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 0960c04 commit 5230d25

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

lib/plsql/package.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def [](object_name)
5656
private
5757

5858
def method_missing(method, *args, &block)
59-
method = method.to_s
59+
method = +method.to_s
6060
method.chop! if (assignment = method[/=$/])
6161

6262
case (object = self[method])

lib/plsql/procedure.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ def construct_argument_list_for_overloads # :nodoc:
315315
def ensure_tmp_tables_created(overload) # :nodoc:
316316
return if @tmp_tables_created.nil? || @tmp_tables_created[overload]
317317
@tmp_table_names[overload] && @tmp_table_names[overload].each do |table_name, argument_metadata|
318-
sql = "CREATE GLOBAL TEMPORARY TABLE #{table_name} (\n"
318+
sql = +"CREATE GLOBAL TEMPORARY TABLE #{table_name} (\n"
319319
element_metadata = argument_metadata[:element]
320320
case element_metadata[:data_type]
321321
when "PL/SQL RECORD"

lib/plsql/procedure_call.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,10 @@ def matching_oracle_types_for_ruby_value(value)
149149
end
150150

151151
def construct_sql(args)
152-
@declare_sql = ""
153-
@assignment_sql = ""
154-
@call_sql = ""
155-
@return_sql = ""
152+
@declare_sql = +""
153+
@assignment_sql = +""
154+
@call_sql = +""
155+
@return_sql = +""
156156
@return_vars = []
157157
@return_vars_metadata = {}
158158

@@ -218,7 +218,7 @@ def construct_sql(args)
218218
end
219219
add_out_variables
220220

221-
@sql = @declare_sql.empty? ? "" : "DECLARE\n" << @declare_sql
221+
@sql = @declare_sql.empty? ? +"" : +"DECLARE\n" << @declare_sql
222222
@sql << "BEGIN\n" << @assignment_sql << dbms_output_enable_sql << @call_sql << @return_sql << "END;\n"
223223
end
224224

@@ -326,7 +326,7 @@ def add_record_declaration(argument, argument_metadata)
326326
"l_#{argument} #{argument_metadata[:sql_type_name]};\n"
327327
else
328328
fields_metadata = argument_metadata[:fields]
329-
sql = "TYPE t_#{argument} IS RECORD (\n"
329+
sql = +"TYPE t_#{argument} IS RECORD (\n"
330330
sql << record_fields_sorted_by_position(fields_metadata).map do |field|
331331
metadata = fields_metadata[field]
332332
"#{field} #{type_to_sql(metadata)}"
@@ -341,7 +341,7 @@ def record_fields_sorted_by_position(fields_metadata)
341341
end
342342

343343
def record_assignment_sql_values_metadata(argument, argument_metadata, record_value)
344-
sql = ""
344+
sql = +""
345345
bind_values = {}
346346
bind_metadata = {}
347347
(record_value || {}).each do |key, value|

lib/plsql/schema.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ def find_database_object(name, override_schema_name = nil)
234234
end
235235

236236
def _errors(object_schema_name, object_name, object_type)
237-
result = ""
237+
result = +""
238238
previous_line = 0
239239
select_all(
240240
"SELECT e.line, e.position, e.text error_text, s.text source_text

lib/plsql/table.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ def column_names
8787
def select(first_or_all, sql_params = "", *bindvars)
8888
case first_or_all
8989
when :first, :all
90-
select_sql = "SELECT * "
90+
select_sql = +"SELECT * "
9191
when :count
92-
select_sql = "SELECT COUNT(*) "
92+
select_sql = +"SELECT COUNT(*) "
9393
else
9494
raise ArgumentError, "Only :first, :all or :count are supported"
9595
end

0 commit comments

Comments
 (0)