Skip to content

Commit 9b6d0fb

Browse files
yahondaclaude
andcommitted
Remove obsolete ruby-oci8 2.0.3 TIMESTAMP patch
The oci8_patches.rb file patched a fractional seconds bug that only activated for ruby-oci8 2.0.3. Since the project requires ~> 2.1 (and the fix was included in 2.0.4), this patch has been dead code for years. Also bump the runtime version check and update the README to reflect the 2.1 minimum. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 39cf870 commit 9b6d0fb

3 files changed

Lines changed: 2 additions & 29 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ or include gem in Gemfile if using bundler.
135135

136136
In addition install either ruby-oci8 (for MRI/YARV) or copy Oracle JDBC driver to $JRUBY_HOME/lib (for JRuby).
137137

138-
If you are using MRI Ruby implementation then you need to install ruby-oci8 gem (version 2.0.x or 2.1.x)
138+
If you are using MRI Ruby implementation then you need to install ruby-oci8 gem (version 2.1 or higher)
139139
as well as Oracle client, e.g. [Oracle Instant Client](http://www.oracle.com/technetwork/database/features/instant-client/index-097480.html).
140140

141141
If you are using JRuby then you need to download latest [Oracle JDBC driver](http://www.oracle.com/technetwork/database/enterprise-edition/jdbc-112010-090769.html) - either ojdbc7.jar for Java 8 and 7, ojdbc6.jar for Java 6, 7, 8 or ojdbc5.jar for Java 5. You can refer [the support matrix](http://www.oracle.com/technetwork/database/enterprise-edition/jdbc-faq-090281.html#01_03) for details.

lib/plsql/oci8_patches.rb

Lines changed: 0 additions & 25 deletions
This file was deleted.

lib/plsql/oci_connection.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@
1414
raise LoadError, "ERROR: ruby-plsql could not load ruby-oci8 library. #{msg}"
1515
end
1616

17-
require "plsql/oci8_patches"
18-
1917
# check ruby-oci8 version
20-
required_oci8_version = [2, 0, 3]
18+
required_oci8_version = [2, 1, 0]
2119
oci8_version_ints = OCI8::VERSION.scan(/\d+/).map { |s| s.to_i }
2220
if (oci8_version_ints <=> required_oci8_version) < 0
2321
raise LoadError, "ERROR: ruby-oci8 version #{OCI8::VERSION} is too old. Please install ruby-oci8 version #{required_oci8_version.join('.')} or later."

0 commit comments

Comments
 (0)