Prefer ActiveRecord.default_timezone over per-class accessor (#234)

Calling ar_class.default_timezone on Rails 7.0/7.1 prints

  DEPRECATION WARNING: ActiveRecord::Base.default_timezone is
  deprecated and will be removed in Rails 7.1. Use
  ActiveRecord.default_timezone instead.

even though both accessors return the same value. Switch the order so
that we ask the module-level ActiveRecord.default_timezone first when
it is available (AR 7.0+, and the only accessor left in AR 8.0+) and
only fall back to the per-class accessor on pre-7.0 AR where the
module-level one does not exist.

The test in spec/plsql/schema_spec.rb already exercises the
ActiveRecord.default_timezone path via respond_to?, so coverage is
unchanged.

Fixes #234

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: yahonda

lib/plsql/schema.rb

@@ -99,12 +99,15 @@ def default_timezone
         @original_schema.default_timezone
       else
         @default_timezone ||
-          # Use ActiveRecord default_timezone when ActiveRecord connection is used,
-          # preferring the connection's activerecord_class so a subclass override
-          # (available in AR < 8.0) is honored before falling back to the
-          # module-level accessor (AR 7.0+; the only one in AR 8.0+).
-          (@connection && (ar_class = @connection.activerecord_class) &&
-            (ar_class.respond_to?(:default_timezone) ? ar_class.default_timezone : ActiveRecord.default_timezone)) ||
+          # Use ActiveRecord default_timezone when ActiveRecord connection is used.
+          # Prefer the module-level accessor (AR 7.0+; the only one in AR 8.0+) so
+          # that AR 7.0/7.1's deprecation warning for ActiveRecord::Base.default_timezone
+          # is not emitted. Fall back to the per-class accessor only on pre-7.0 AR,
+          # where ActiveRecord.default_timezone does not exist.
+          (@connection && @connection.activerecord_class &&
+            (ActiveRecord.respond_to?(:default_timezone) ?
+              ActiveRecord.default_timezone :
+              @connection.activerecord_class.default_timezone)) ||
           # default to local timezone
           :local
       end