Replace File.exists? with File.exist?#267
Merged
Merged
Conversation
File.exists? was removed in Ruby 4.0 / JRuby 10.1, causing JDBC driver loading to fail with NoMethodError. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Apr 13, 2026
The File.exists? shim is no longer needed now that ruby-plsql has been fixed to use File.exist? in rsim/ruby-plsql#267. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
There was a problem hiding this comment.
Pull request overview
This PR fixes JDBC driver discovery/loading under Ruby 4.0 compatibility (e.g., JRuby-head) by replacing the removed/deprecated File.exists? call with File.exist? in the JDBC connection setup.
Changes:
- Replace
File.exists?withFile.exist?when checking for JDBC driver jar files. - Prevent
NoMethodErrorduring driver loading on Ruby versions whereFile.exists?is removed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File.exists?withFile.exist?injdbc_connection.rbFile.exists?was deprecated in Ruby 2.1 and removed in Ruby 4.0 / JRuby 10.1, causing JDBC driver loading to fail withNoMethodError: undefined method 'exists?' for class FileTest plan
🤖 Generated with Claude Code