Replace if not value.nil? with unless value.nil?

[yahonda]

Summary

In add_argument's XMLTYPE branch, two adjacent trailing modifiers used the awkward double-negation form:

@assignment_sql << "l_#{argument} := XMLTYPE(:#{argument});\n" if not value.nil?
@bind_values[argument] = value if not value.nil?

Replace each with unless value.nil? — same semantics, idiomatic Ruby, same line count.

@assignment_sql << "l_#{argument} := XMLTYPE(:#{argument});\n" unless value.nil?
@bind_values[argument] = value unless value.nil?

Scope is intentionally narrow. The remaining if !x.empty? at procedure_call.rb:105 pairs with an elsif !x.empty? at line 107 where unless cannot be substituted, so it is left alone for symmetry.

Diff stat: lib/plsql/procedure_call.rb | 4 ++-- (+2 / -2, two single-line changes).

Test plan

• bundle exec rspec — 468 examples, 0 failures, 1 pre-existing pending
• Grep confirms no remaining if not constructs in lib/plsql/procedure_call.rb outside of a code comment that legitimately mentions "if not overloaded"

🤖 Generated with Claude Code