Merge pull request #22 from saidshahdev/feature-collection-utils-tests

Feature collection utils tests

Author: brandongregoryscott

src/utilities/collection-utils.test.ts

@@ -72,7 +72,7 @@ describe("CollectionUtils", () => {
             expect(result).toBeFalse();
         });
 
-        test("when collections param is undefined, it returns false", (): void => {
+        test("given collections is undefined, it returns false", (): void => {
             // Arrange & Act
             const result = CollectionUtils.hasValues(
                 (undefined as unknown) as any[]
@@ -82,7 +82,7 @@ describe("CollectionUtils", () => {
             expect(result).toBeFalse();
         });
 
-        test("when collections param is null, it returns false", (): void => {
+        test("given collections is null, it returns false", (): void => {
             // Arrange & Act
             const result = CollectionUtils.hasValues(
                 (null as unknown) as any[]
@@ -179,7 +179,7 @@ describe("CollectionUtils", () => {
             expect(result).toBeTrue();
         });
 
-        test("when collections param is undefined, it returns true", (): void => {
+        test("given collections is undefined, it returns true", (): void => {
             // Arrange & Act
             const result = CollectionUtils.isEmpty(
                 (undefined as unknown) as any[]
@@ -189,7 +189,7 @@ describe("CollectionUtils", () => {
             expect(result).toBeTrue();
         });
 
-        test("when collections param is null, it returns true", (): void => {
+        test("given collections is null, it returns true", (): void => {
             // Arrange & Act
             const result = CollectionUtils.isEmpty((null as unknown) as any[]);
 

src/utilities/collection-utils.ts

@@ -58,10 +58,6 @@ const _equalsBy = function<T, V>(
 const _hasValues = (
     ...collections: Array<any[] | List<any> | undefined>
 ): boolean => {
-    if (collections == null) {
-        return false;
-    }
-
     let hasValues = false;
     collections.forEach((collection: any[] | List<any> | undefined) => {
         if (!_isEmpty(collection)) {
@@ -85,10 +81,6 @@ const _hasValues = (
 const _isEmpty = (
     ...collections: Array<any[] | List<any> | undefined>
 ): boolean => {
-    if (collections == null) {
-        return true;
-    }
-
     let isEmpty = true;
 
     collections.forEach((collection: any[] | List<any> | undefined) => {