added tests for isEmpty and hasValues methods in CollectionUtils

Author: Said Shah

src/utilities/collection-utils.test.ts

@@ -4,6 +4,28 @@ import { ResultRecord } from "../view-models/result-record";
 
 describe("CollectionUtils", () => {
     describe("hasValues", () => {
+        test("when collections param is null, it returns false", (): void => {
+            // Arrange
+            const collection = null;
+
+            // Act
+            const result = CollectionUtils.hasValues(collection);
+
+            // Assert
+            expect(result).toBeFalse();
+        });
+
+        test("when collections param is undefined, it returns false", (): void => {
+            // Arrange
+            const collection = undefined;
+
+            // Act
+            const result = CollectionUtils.hasValues(collection);
+
+            // Assert
+            expect(result).toBeFalse();
+        });
+
         test("when collections param is an array and has elements, it returns true", (): void => {
             // Arrange
             const collection = [{}];
@@ -111,6 +133,28 @@ describe("CollectionUtils", () => {
     }); // end hasValues
 
     describe("isEmpty", () => {
+        test(`when collections is null, it returns true`, (): void => {
+            // Arrange
+            const collection = null;
+
+            // Act
+            const result = CollectionUtils.isEmpty(collection);
+
+            // Assert
+            expect(result).toBeTrue();
+        });
+
+        test(`when collections is undefined, it returns true`, (): void => {
+            // Arrange
+            const collection = undefined;
+
+            // Act
+            const result = CollectionUtils.isEmpty(collection);
+
+            // Assert
+            expect(result).toBeTrue();
+        });
+
         test(`when collections param is an array and has elements, it returns false`, (): void => {
             // Arrange
             const collection = [{}];

src/utilities/collection-utils.ts

@@ -58,9 +58,6 @@ const _equalsBy = function<T, V>(
 const _hasValues = (
     ...collections: Array<any[] | List<any> | undefined>
 ): boolean => {
-    if (collections == null) {
-        return false;
-    }
 
     let hasValues = false;
     collections.forEach((collection: any[] | List<any> | undefined) => {
@@ -85,9 +82,6 @@ const _hasValues = (
 const _isEmpty = (
     ...collections: Array<any[] | List<any> | undefined>
 ): boolean => {
-    if (collections == null) {
-        return true;
-    }
 
     let isEmpty = true;