Remove no-caps eslint override (#77)

Author: myty

.changeset/smart-penguins-deliver.md

@@ -0,0 +1,6 @@
+---
+"@rsm-hcd/eslint-config-custom": patch
+"@rsm-hcd/javascript-core": patch
+---
+
+Update eslint rules: removed no-caps override

.changeset/three-cheetahs-happen.md

@@ -0,0 +1,6 @@
+---
+"@rsm-hcd/javascript-testing": patch
+"@rsm-hcd/javascript-core": patch
+---
+
+update dependencies

packages/eslint-config-custom/library.js

@@ -64,7 +64,6 @@ module.exports = {
         "import/no-default-export": "off", // TODO: https://github.com/rsm-hcd/hcd-javascript/issues/59
         "import/no-named-as-default-member": "off", // TODO: https://github.com/rsm-hcd/hcd-javascript/issues/60
         "import/no-named-as-default": "off", // TODO: https://github.com/rsm-hcd/hcd-javascript/issues/63
-        "new-cap": "off", // TODO: https://github.com/rsm-hcd/hcd-javascript/issues/64
         "no-await-in-loop": "off", // TODO: https://github.com/rsm-hcd/hcd-javascript/issues/65
         "no-console": "off", // TODO: https://github.com/rsm-hcd/hcd-javascript/issues/66
         "no-constant-binary-expression": "off", // TODO: https://github.com/rsm-hcd/hcd-javascript/issues/67

packages/javascript-core/package.json

@@ -19,7 +19,7 @@
         "query-string": "6.13.1"
     },
     "devDependencies": {
-        "@faker-js/faker": "^8.1.0",
+        "@faker-js/faker": "^8.2.0",
         "@rsm-hcd/eslint-config-custom": "workspace:*",
         "@rsm-hcd/tsconfig": "workspace:*",
         "@swc/core": "^1.3.92",
@@ -56,7 +56,7 @@
         "Node"
     ],
     "peerDependencies": {
-        "@faker-js/faker": "^8.1.0",
+        "@faker-js/faker": "^8.2.0",
         "axios": "^1.5.1",
         "immutable": "^4.3.4",
         "jest": "^29.7.0",

packages/javascript-core/src/utilities/record-utils.ts

@@ -1,4 +1,4 @@
-import { Record } from "immutable";
+import { Record as ImmutableRecord } from "immutable";
 import { AuditableDefaultValues } from "../constants/auditable-default-values";
 import type { Auditable } from "../interfaces/auditable";
 import type { Constructor } from "../types/constructor";
@@ -38,15 +38,15 @@ const RecordUtils = {
      * If `maybeRecord` is already an instance of `T`, it returns that value.
      *
      * @param maybeRecord Object or Record to be coalesced into a Record.
-     * @param record Type of the Record to be instantiated
+     * @param Record Type of the Record to be instantiated
      */
     ensureRecord<TValue, TRecord extends TValue>(
         maybeRecord: TValue,
-        record: Constructor<TRecord>
+        Record: Constructor<TRecord>
     ): TRecord {
-        return RecordUtils.isRecord(maybeRecord, record)
+        return RecordUtils.isRecord(maybeRecord, Record)
             ? maybeRecord
-            : new record(maybeRecord);
+            : new Record(maybeRecord);
     },
 
     /**
@@ -77,7 +77,10 @@ const RecordUtils = {
         maybeRecord: TValue,
         record: Constructor<TRecord>
     ): maybeRecord is TRecord {
-        return Record.isRecord(maybeRecord) && maybeRecord instanceof record;
+        return (
+            ImmutableRecord.isRecord(maybeRecord) &&
+            maybeRecord instanceof record
+        );
     },
 };
 

packages/javascript-testing/package.json

@@ -14,7 +14,7 @@
         }
     },
     "devDependencies": {
-        "@faker-js/faker": "^8.1.0",
+        "@faker-js/faker": "^8.2.0",
         "@rsm-hcd/eslint-config-custom": "workspace:*",
         "@rsm-hcd/tsconfig": "workspace:*",
         "@swc/core": "^1.3.92",
@@ -44,7 +44,7 @@
     ],
     "license": "MIT",
     "peerDependencies": {
-        "@faker-js/faker": "^8.1.0",
+        "@faker-js/faker": "^8.2.0",
         "axios": "^1.5.1",
         "immutable": "^4.3.4",
         "jest": "^29.7.0",

pnpm-lock.yaml

@@ -27,8 +27,11 @@
             ],
             "outputs": [
                 "dist/**"
-            ]},
-        "lint": {},
+            ]
+        },
+        "lint": {
+            "cache": false
+        },
         "lint:fix": {},
         "test": {
             "dependsOn": [