verify that idled PVCs are deleted (codeready-toolchain#1249)

Author: MatousJobanek

test/e2e/parallel/user_workloads_test.go

@@ -111,6 +111,10 @@ func TestIdlerAndPriorityClass(t *testing.T) {
 	// Wait for the DataVolume to be deleted
 	err = memberAwait.WaitUntilDataVolumeDeleted(t, "test-idler-datavolume", idler.Name, clnt.Resource(dataVolumeRes))
 	require.NoError(t, err)
+
+	// Wait for the PVC to be deleted
+	err = memberAwait.WaitUntilPVCDeleted(t, "test-idler-pvc", idler.Name)
+	require.NoError(t, err)
 }
 
 func prepareIdlerUser(t *testing.T, await wait.Awaitilities, name string) (*toolchainv1alpha1.Idler, *toolchainv1alpha1.Idler) {
@@ -170,6 +174,10 @@ func prepareWorkloads(t *testing.T, memberAwait *wait.MemberAwaitility, namespac
 	createDataVolume(t, memberAwait, "test-idler-datavolume", namespace)
 	n = n + 1
 
+	// Create a PVC and Pod
+	createPvcWithPod(t, memberAwait, "test-idler-pvc", namespace, nil)
+	n = n + 1
+
 	servingRuntimeDeployment := createKServeWorkloads(t, memberAwait, "test-idler-kserve", namespace)
 	n = n + int(*servingRuntimeDeployment.Spec.Replicas)
 

testsupport/wait/member.go

@@ -1573,6 +1573,27 @@ func (a *MemberAwaitility) WaitUntilDataVolumeDeleted(t *testing.T, name, namesp
 	return err
 }
 
+// WaitUntilPVCDeleted waits for the PVC resource to be deleted (idled)
+func (a *MemberAwaitility) WaitUntilPVCDeleted(t *testing.T, name, namespace string) error {
+	t.Logf("waiting for PVC '%s' to be deleted in namespace '%s'", name, namespace)
+	pvc := &corev1.PersistentVolumeClaim{}
+	err := wait.PollUntilContextTimeout(context.TODO(), a.RetryInterval, a.Timeout, true, func(ctx context.Context) (bool, error) {
+		pvc = &corev1.PersistentVolumeClaim{}
+		err := a.Client.Get(ctx, test.NamespacedName(namespace, name), pvc)
+		if err != nil {
+			if errors.IsNotFound(err) {
+				return true, nil
+			}
+			return false, err
+		}
+		return false, nil
+	})
+	if err != nil {
+		t.Logf("failed waiting for PVC '%s' to be deleted in namespace '%s': %q", name, namespace, pvc)
+	}
+	return err
+}
+
 // WaitForPods waits until "n" number of pods exist in the given namespace
 func (a *MemberAwaitility) WaitForPods(t *testing.T, namespace string, n int, criteria ...PodWaitCriterion) ([]corev1.Pod, error) {
 	t.Logf("waiting for Pods in namespace '%s' with matching criteria", namespace)