test: fix space counter (codeready-toolchain#1212)

* check if space was deleted

* requested changes

* requested changes

---------

Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>

Author: 3 people

test/migration/setup_runner.go

@@ -166,7 +166,11 @@ func (r *SetupMigrationRunner) prepareDeactivatedUser(t *testing.T) {
 	t.Logf("user signup '%s' set to deactivated", userSignup.Name)
 
 	// verify that MUR is deleted
-	err = hostAwait.WaitUntilMasterUserRecordAndSpaceBindingsDeleted(t, userSignup.Status.CompliantUsername) // TODO wait for space deletion too after Space migration is done
+	err = hostAwait.WaitUntilMasterUserRecordAndSpaceBindingsDeleted(t, userSignup.Status.CompliantUsername)
+	require.NoError(t, err)
+
+	// verify that space (and space binding) is deleted, to be sure that the space counter is decremented
+	err = hostAwait.WaitUntilSpaceAndSpaceBindingsDeleted(t, userSignup.Status.CompliantUsername)
 	require.NoError(t, err)
 }
 
@@ -185,6 +189,10 @@ func (r *SetupMigrationRunner) prepareBannedUser(t *testing.T) {
 	_, err = hostAwait.WithRetryOptions(wait.TimeoutOption(time.Second*15)).WaitForUserSignup(t, userSignup.Name,
 		wait.ContainsCondition(wait.Banned()[0]))
 	require.NoError(t, err)
+
+	// verify that space (and space binding) is deleted, to be sure that the space counter is decremented
+	err = hostAwait.WaitUntilSpaceAndSpaceBindingsDeleted(t, userSignup.Status.CompliantUsername)
+	require.NoError(t, err)
 }
 
 func (r *SetupMigrationRunner) prepareAppStudioProvisionedUser(t *testing.T) {