changing AsyncServerSocket::acceptError to receive exception_wrapper

yairgott · facebook-github-bot · commit 6334b5f24d1b · 2021-02-20T08:01:46.000-08:00
Reviewed By: yfeldblum

Differential Revision: D25514804

fbshipit-source-id: 7e6ad5c6063d2cf5047f656c0f2336b34576c60b
diff --git a/rsocket/benchmarks/BaselinesAsyncSocket.cpp b/rsocket/benchmarks/BaselinesAsyncSocket.cpp
@@ -119,8 +119,8 @@
 //        std::move(socket), eventBase_, loadSize_, recvBufferLength_);
 //  }
 //
-//  void acceptError(const std::exception& ex) noexcept override {
-//    LOG(FATAL) << "acceptError" << ex.what() << std::endl;
+//  void acceptError(folly::exception_wrapper ex) noexcept override {
+//    LOG(FATAL) << "acceptError" << ex << std::endl;
 //    eventBase_.terminateLoopSoon();
 //  }
 //
diff --git a/rsocket/transports/tcp/TcpConnectionAcceptor.cpp b/rsocket/transports/tcp/TcpConnectionAcceptor.cpp
@@ -43,8 +43,8 @@ class TcpConnectionAcceptor::SocketCallback
     onAccept_(std::move(connection), *eventBase());
   }
 
-  void acceptError(const std::exception& ex) noexcept override {
-    VLOG(2) << "TCP error: " << ex.what();
+  void acceptError(folly::exception_wrapper ex) noexcept override {
+    VLOG(2) << "TCP error: " << ex;
   }
 
   folly::EventBase* eventBase() const {

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,8 @@ class TcpConnectionAcceptor::SocketCallback`
`43`	`43`	`onAccept_(std::move(connection), *eventBase());`
`44`	`44`	`}`
`45`	`45`
`46`		`- void acceptError(const std::exception& ex) noexcept override {`
`47`		`- VLOG(2) << "TCP error: " << ex.what();`
	`46`	`+ void acceptError(folly::exception_wrapper ex) noexcept override {`
	`47`	`+ VLOG(2) << "TCP error: " << ex;`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`folly::EventBase* eventBase() const {`