Fix buffer overflow panics in frame metadata parsing#150
Merged
jjeffcaii merged 1 commit intoJun 15, 2026
Merged
Conversation
Contributor
Author
Lint error looks unrelated to the change |
58cb282 to
9503cd1
Compare
Add bounds checks in trySeekMetadataLen, trySliceMetadata, and trySliceData so malformed frames with a bogus metadata length return nil instead of panicking on the slice expression.
9503cd1 to
6e0c262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bounds checks in trySeekMetadataLen, trySliceMetadata, and trySliceData
so malformed frames with a bogus metadata length return nil instead of
panicking on the slice expression.