Commit 52a670f
Properly propagate exceptions type from server client. (#150)
***Problem***
Errors generated from the `Responder` are serialized according to the spec
https://github.com/ReactiveSocket/reactivesocket/blob/master/Protocol.md#error-codes
but the type is lost when deserializing by the `Requester`.
***Solution***
Instead of generating a RuntimeException containing the string of the error,
generate the right Exception type based on the error code.
This allow user code, or filter to make smart decision based on the Exception
type (Retryable, ...)1 parent 085b6e8 commit 52a670f
4 files changed
Lines changed: 7 additions & 8 deletions
File tree
- reactivesocket-core/src
- main/java/io/reactivesocket
- exceptions
- internal
- test/java/io/reactivesocket
- internal
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | 27 | | |
Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | 18 | | |
20 | 19 | | |
21 | 20 | | |
| |||
837 | 836 | | |
838 | 837 | | |
839 | 838 | | |
840 | | - | |
841 | | - | |
842 | | - | |
| 839 | + | |
| 840 | + | |
843 | 841 | | |
844 | 842 | | |
845 | 843 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
182 | 183 | | |
183 | 184 | | |
184 | 185 | | |
185 | | - | |
| 186 | + | |
186 | 187 | | |
187 | 188 | | |
188 | 189 | | |
| |||
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
165 | 166 | | |
166 | 167 | | |
167 | 168 | | |
168 | | - | |
| 169 | + | |
169 | 170 | | |
170 | 171 | | |
171 | 172 | | |
| |||
313 | 314 | | |
314 | 315 | | |
315 | 316 | | |
316 | | - | |
| 317 | + | |
317 | 318 | | |
318 | 319 | | |
319 | 320 | | |
| |||
0 commit comments