redundant condition (#394)

qweek · yschimke · commit 5ecf9f9a2ba8 · 2017-09-17T06:49:01.000+01:00
Condition 'metadata != null' is always 'true' when reached
diff --git a/rsocket-core/src/main/java/io/rsocket/frame/FrameHeaderFlyweight.java b/rsocket-core/src/main/java/io/rsocket/frame/FrameHeaderFlyweight.java
@@ -103,7 +103,7 @@ public static int encodeMetadata(
       typeAndFlags |= FLAGS_M;
       byteBuf.setShort(FRAME_TYPE_AND_FLAGS_FIELD_OFFSET, (short) typeAndFlags);
 
-      if (hasMetadataLengthField(frameType) && metadata != null) {
+      if (hasMetadataLengthField(frameType)) {
         encodeLength(byteBuf, metadataOffset, metadataLength);
         length += FRAME_LENGTH_SIZE;
       }

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ public static int encodeMetadata(`
`103`	`103`	`typeAndFlags \|= FLAGS_M;`
`104`	`104`	`byteBuf.setShort(FRAME_TYPE_AND_FLAGS_FIELD_OFFSET, (short) typeAndFlags);`
`105`	`105`
`106`		`- if (hasMetadataLengthField(frameType) && metadata != null) {`
	`106`	`+ if (hasMetadataLengthField(frameType)) {`
`107`	`107`	`encodeLength(byteBuf, metadataOffset, metadataLength);`
`108`	`108`	`length += FRAME_LENGTH_SIZE;`
`109`	`109`	`}`