fix: skip esbuild's RSS metrics

Author: chenjiahan

README.md

@@ -138,7 +138,7 @@ Build metrics:
 | Vite (Rolldown) 7.2.2  | 1893ms🥉         | 1724ms             | 905MB        | 2056.6kB🥈  | 633.1kB      |
 | Rolldown 1.0.0-beta.47 | 1198ms🥇         | 1323ms🥈           | 862MB        | 2074.1kB    | 635.1kB      |
 | webpack (SWC) 5.102.1  | 15453ms          | 8506ms             | 1730MB       | 2056.9kB    | 630.9kB🥉    |
-| esbuild 0.27.0         | 1746ms🥈         | 1643ms🥉           | 66MB🥇       | 2896.9kB    | 888.7kB      |
+| esbuild 0.27.0         | 1746ms🥈         | 1643ms🥉           | N/A          | 2896.9kB    | 888.7kB      |
 | Farm 1.7.11            | 6571ms           | 1923ms             | 1305MB       | 3822.7kB    | 1330.7kB     |
 | Parcel 2.16.1          | 11718ms          | 981ms🥇            | 2028MB       | 2095.4kB    | 637.6kB      |
 
@@ -158,7 +158,7 @@ Build metrics:
 | Rsbuild 1.6.3          | 616ms            | 522ms              | 245MB🥉      | 1008.0kB🥈  | 270.9kB🥉    |
 | Rolldown 1.0.0-beta.47 | 298ms🥈          | 301ms🥈            | 220MB🥈      | 1012.2kB    | 271.8kB      |
 | webpack (SWC) 5.102.1  | 3168ms           | 905ms              | 678MB        | 1006.2kB🥇  | 270.5kB🥇    |
-| esbuild 0.27.0         | 266ms🥇          | 256ms🥇            | 65MB🥇       | 1025.3kB    | 276.7kB      |
+| esbuild 0.27.0         | 266ms🥇          | 256ms🥇            | N/A          | 1025.3kB    | 276.7kB      |
 
 ## Run locally
 

scripts/benchmark.ts

@@ -19,6 +19,7 @@ import {
   addRankingEmojis,
   shuffleArray,
   sleep,
+  N_A,
 } from './utils.ts';
 
 process.env.CASE = caseName;
@@ -115,6 +116,7 @@ interface BuildToolOptions {
   startedRegex: RegExp;
   buildScript: string;
   binFilePath: string;
+  skipRss?: boolean;
 }
 
 class BuildTool {
@@ -124,6 +126,7 @@ class BuildTool {
   private readonly startedRegex: RegExp;
   private readonly buildScript: string;
   private readonly binFilePath: string;
+  public readonly skipRss: boolean;
 
   constructor({
     name,
@@ -132,6 +135,7 @@ class BuildTool {
     startedRegex,
     buildScript,
     binFilePath,
+    skipRss = false,
   }: BuildToolOptions) {
     this.name = name;
     this.port = port;
@@ -140,6 +144,7 @@ class BuildTool {
     this.buildScript = buildScript;
     this.binFilePath = path.join(process.cwd(), 'node_modules', binFilePath);
     this.hackBinFile();
+    this.skipRss = skipRss;
   }
 
   cleanCache(): void {
@@ -418,6 +423,8 @@ parseToolNames().forEach((name) => {
           startedRegex: /esbuild built in (\d+) ms/,
           buildScript: 'build:esbuild',
           binFilePath: 'esbuild/lib/main.js',
+          // can not collect accurate RSS from esbuild
+          skipRss: true,
         }),
       );
       break;
@@ -504,7 +511,7 @@ async function runDevBenchmark(
   const loadTime = Date.now() - start;
   logger.success(
     color.dim(buildTool.name) +
-      ' dev cold start in ' +
+      ' dev start in ' +
       color.green(time + loadTime + 'ms'),
   );
   metrics.devColdStart = time + loadTime;
@@ -622,7 +629,7 @@ async function runHotStartBenchmark(
 
   logger.info(
     color.dim(
-      'navigating to' + ` http://localhost:${buildTool.port} (hot start)`,
+      'navigating to' + ` http://localhost:${buildTool.port} (with cache)`,
     ),
   );
 
@@ -637,7 +644,7 @@ async function runHotStartBenchmark(
   const loadTime = Date.now() - start;
   logger.success(
     color.dim(buildTool.name) +
-      ' dev hot start in ' +
+      ' dev start with cache in ' +
       color.green(time + loadTime + 'ms'),
   );
   metrics.devHotStart = time + loadTime;
@@ -647,7 +654,7 @@ async function runHotStartBenchmark(
   await stopServer();
 
   await coolDown();
-  logger.success(color.dim(buildTool.name) + ' dev server closed (hot start)');
+  logger.success(color.dim(buildTool.name) + ' dev server closed (with cache)');
 }
 
 async function runBuildBenchmark(
@@ -700,7 +707,7 @@ async function runHotBuildBenchmark(
 
   logger.success(
     color.dim(buildTool.name) +
-      ' hot built in ' +
+      ' built with cache in ' +
       color.green(buildTime + 'ms'),
   );
 
@@ -791,7 +798,16 @@ const getData = function (
     // and should be hidden
     return null;
   }
-  const normalized = dataset.map((item) => `${item as number | string}${unit}`);
+
+  const normalized = dataset.map((item, index) => {
+    if (
+      buildTools[index].skipRss &&
+      ['devRSS', 'buildRSS'].includes(fieldName)
+    ) {
+      return N_A;
+    }
+    return `${item as number | string}${unit}`;
+  });
   addRankingEmojis(normalized);
   return normalized;
 };

scripts/utils.ts

@@ -3,6 +3,8 @@ import fse from 'fs-extra';
 import glob from 'fast-glob';
 import { gzipSizeSync } from 'gzip-size';
 
+export const N_A = 'N/A';
+
 // fast-glob only accepts posix path
 // https://github.com/mrmlnc/fast-glob#convertpathtopatternpath
 function convertPath(path: string) {
@@ -52,7 +54,10 @@ export async function getFileSizes(targetDir: string) {
 export function addRankingEmojis(data: string[], sort = 'ASC') {
   const values = data.map((originalValue, index) => ({
     index,
-    value: parseFloat(originalValue),
+    value:
+      originalValue === N_A
+        ? Number.MAX_SAFE_INTEGER
+        : parseFloat(originalValue),
     originalValue,
   }));
 
@@ -70,7 +75,9 @@ export function addRankingEmojis(data: string[], sort = 'ASC') {
 
   values.forEach((item, rank) => {
     const emoji = rank < 3 ? emojis[rank] : '';
-    data[item.index] = item.originalValue + emoji;
+    if (item.originalValue !== N_A) {
+      data[item.index] = item.originalValue + emoji;
+    }
   });
 }