Skip to content

chore: optimize CI pnpm setup#38

Merged
chenjiahan merged 1 commit into
mainfrom
codex/optimize-ci-pnpm-action-20260609
Jun 10, 2026
Merged

chore: optimize CI pnpm setup#38
chenjiahan merged 1 commit into
mainfrom
codex/optimize-ci-pnpm-action-20260609

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR aligns the GitHub Actions pnpm setup with the current Rsbuild workflow pattern from web-infra-dev/rsbuild#7856.

  • Replace corepack/manual pnpm install steps with pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 and run_install: true.
  • Explicitly disable actions/setup-node package manager caching with package-manager-cache: false.
  • Keep browser installation commands as separate post-install steps where needed.

@chenjiahan chenjiahan marked this pull request as ready for review June 9, 2026 03:57
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3bce5eed-c321-4694-b3a4-75069f47e17a

📥 Commits

Reviewing files that changed from the base of the PR and between fd5df45 and a17b3e4.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • .github/workflows/test.yml

📝 Walkthrough

Walkthrough

This PR consolidates the pnpm dependency setup across two GitHub workflows. The release and test workflows previously used inline corepack commands to enable pnpm followed by manual pnpm install. Both workflows now consistently use actions/setup-node (with package-manager-cache disabled) paired with the dedicated pnpm/action-setup action configured with run_install: true. The build and test execution steps remain unchanged.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: optimizing the CI pnpm setup process by updating GitHub Actions workflows.
Description check ✅ Passed The description is directly related to the changeset, detailing the specific workflow updates to pnpm setup configuration and rationale for alignment with rsbuild patterns.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-ci-pnpm-action-20260609

Comment @coderabbitai help to get the list of available commands and usage tips.

@chenjiahan chenjiahan merged commit 1ef638c into main Jun 10, 2026
5 checks passed
@chenjiahan chenjiahan deleted the codex/optimize-ci-pnpm-action-20260609 branch June 10, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant