fix: unexpected cache hit when modifiedFiles size 0#47
Merged
Conversation
colinaaa
approved these changes
Mar 31, 2025
Collaborator
colinaaa
left a comment
colinaaa
left a comment
There was a problem hiding this comment.
BTW, I'm curious why postcssProcessorCache is set as a static method. postcssProcessorCache uses entryName as the cache key, which makes the cache not strict when running rspack multiple times & there is an import cache.
I think it was a mistake :)
colinaaa
pushed a commit
that referenced
this pull request
Mar 31, 2025
Use instance `postcssProcessorCache` attribute instead of static `postcssProcessorCache` in `TailwindRspackPluginImpl` class. Avoid unexpected cache hits due to import cache when multiple builds. related: #47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unexpected cache hit in CI when modifiedFiles size 0 (matched pre test case cache).
BTW, I'm curious why
postcssProcessorCacheis set as a static method.postcssProcessorCacheusesentryNameas the cache key, which makes the cache not strict when running rspack multiple times & there is an import cache.https://github.com/rspack-contrib/rsbuild-ecosystem-ci/actions/runs/14164766016/job/39675948751