chore(deps): upgrade ts-checker-rspack-plugin to v1.5.0#86
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe PR updates TypeScript Go handling to auto-enable for TypeScript 7+ and adjusts default 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a387a980d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tsgo: projectTypescript?.tsgo ?? false, | ||
| // use typescript of user project | ||
| typescriptPath: projectTypescriptPath, | ||
| typescriptPath: projectTypescript?.typescriptPath, |
There was a problem hiding this comment.
Restore the classic TypeScript path when tsgo is disabled
In a TypeScript 7 project, resolveProjectTypeScript now makes the default typescriptPath point at typescript/package.json; if a user opts out of the experimental Go checker with tsCheckerOptions.typescript.tsgo = false, that package.json path is still passed to the normal TypeScript reporter. ts-checker-rspack-plugin v1.5 rejects package.json paths in non-tsgo mode and expects the module entry from require.resolve('typescript'), so TS 7 projects that disable tsgo fail during checker setup instead of falling back to the classic checker. Please switch this path back to the module entry after merging when tsgo is false.
Useful? React with 👍 / 👎.
Summary
This PR upgrades
ts-checker-rspack-pluginto v1.5.0 so@rsbuild/plugin-type-checkcan use the upstream TypeScript 7 RC /tsgosupport. It updates default TypeScript resolution to passtypescript/package.jsonand enabletsgowhen a project installs TypeScript 7+, keeps the@typescript/native-previewfallback for older TypeScript projects, and adds an e2e fixture pinned totypescript@7.0.1-rc.Related Links
https://github.com/rstackjs/ts-checker-rspack-plugin/releases/tag/v1.5.0