Skip to content

chore(deps): upgrade ts-checker-rspack-plugin to v1.5.0#86

Closed
chenjiahan wants to merge 1 commit into
mainfrom
chenjiahan/chore-upgrade-ts-checker-rspack-1-5
Closed

chore(deps): upgrade ts-checker-rspack-plugin to v1.5.0#86
chenjiahan wants to merge 1 commit into
mainfrom
chenjiahan/chore-upgrade-ts-checker-rspack-1-5

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

This PR upgrades ts-checker-rspack-plugin to v1.5.0 so @rsbuild/plugin-type-check can use the upstream TypeScript 7 RC / tsgo support. It updates default TypeScript resolution to pass typescript/package.json and enable tsgo when a project installs TypeScript 7+, keeps the @typescript/native-preview fallback for older TypeScript projects, and adds an e2e fixture pinned to typescript@7.0.1-rc.

Related Links

https://github.com/rstackjs/ts-checker-rspack-plugin/releases/tag/v1.5.0

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8cb21c39-eebf-423b-b615-0317889f6ef1

📥 Commits

Reviewing files that changed from the base of the PR and between 616fbd2 and 9a387a9.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • README.md
  • package.json
  • pnpm-workspace.yaml
  • src/index.ts
  • test/typescript-v7-rc/index.test.ts
  • test/typescript-v7-rc/package.json
  • test/typescript-v7-rc/src/index.ts
  • test/typescript-v7-rc/tsconfig.json

📝 Walkthrough

Walkthrough

The PR updates TypeScript Go handling to auto-enable for TypeScript 7+ and adjusts default typescriptPath resolution and fallback behavior. It also updates the README, bumps ts-checker-rspack-plugin, adds workspace configuration for a new TypeScript v7 RC test package, and introduces an E2E test fixture that exercises a type-check failure under TypeScript 7 RC.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: upgrading ts-checker-rspack-plugin to v1.5.0.
Description check ✅ Passed The description matches the changeset and clearly explains the dependency upgrade, TypeScript 7 support, and new e2e fixture.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/chore-upgrade-ts-checker-rspack-1-5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a387a980d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/index.ts
tsgo: projectTypescript?.tsgo ?? false,
// use typescript of user project
typescriptPath: projectTypescriptPath,
typescriptPath: projectTypescript?.typescriptPath,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the classic TypeScript path when tsgo is disabled

In a TypeScript 7 project, resolveProjectTypeScript now makes the default typescriptPath point at typescript/package.json; if a user opts out of the experimental Go checker with tsCheckerOptions.typescript.tsgo = false, that package.json path is still passed to the normal TypeScript reporter. ts-checker-rspack-plugin v1.5 rejects package.json paths in non-tsgo mode and expects the module entry from require.resolve('typescript'), so TS 7 projects that disable tsgo fail during checker setup instead of falling back to the classic checker. Please switch this path back to the module entry after merging when tsgo is false.

Useful? React with 👍 / 👎.

@chenjiahan

Copy link
Copy Markdown
Member Author

#87

@chenjiahan chenjiahan closed this Jun 25, 2026
@chenjiahan chenjiahan deleted the chenjiahan/chore-upgrade-ts-checker-rspack-1-5 branch June 25, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant