Skip to content

chore: fix failed CI after updating deps#100

Merged
chenjiahan merged 2 commits into
mainfrom
fix_deps_0303
Mar 3, 2026
Merged

chore: fix failed CI after updating deps#100
chenjiahan merged 2 commits into
mainfrom
fix_deps_0303

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Updates the project to use @rspack/cli and @rspack/core version 2.0.0-beta.4 instead of the previous canary release. It also updates the Renovate configuration and corrects a couple of test expectations.

Copilot AI review requested due to automatic review settings March 3, 2026 04:08
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on stabilizing the project's dependencies by upgrading Rspack packages to a beta version and refining the automated dependency management. It also includes necessary updates to test expectations and minor code formatting improvements to ensure the project remains robust and maintainable following these dependency changes.

Highlights

  • Dependency Updates: Updated @rspack/cli and @rspack/core to version 2.0.0-beta.4 across the project, moving from a canary release to a more stable beta.
  • Renovate Configuration Migration: Migrated the Renovate configuration from .github/renovate.json5 to .github/renovate.json, and added specific instructions to ignore @rspack/core and @rspack/cli dependencies to prevent unintended updates.
  • Test Expectation Adjustments: Adjusted several test snapshots and assertions to reflect changes in expected content types for JavaScript files (from application/javascript to text/javascript) and updated client reconnect messages.
  • Code Readability Improvements: Refactored require.resolve calls in src/server.ts and several test files to improve code readability by removing unnecessary line breaks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .github/renovate.json
    • Added a new Renovate configuration file in JSON format.
    • Configured Renovate to extend from github>rstackjs/renovate.
    • Explicitly ignored @rspack/core and @rspack/cli from Renovate updates.
  • .github/renovate.json5
    • Removed the old Renovate configuration file in JSON5 format.
  • example/package.json
    • Updated @rspack/cli from 2.0.0-canary-20260116 to 2.0.0-beta.4.
    • Updated @rspack/core from 2.0.0-canary-20260116 to 2.0.0-beta.4.
  • package.json
    • Updated @rspack/core from 2.0.0-canary-20260116 to 2.0.0-beta.4.
  • pnpm-lock.yaml
    • Updated various @rspack binding packages (e.g., darwin-arm64, darwin-x64, linux-arm64-gnu, linux-arm64-musl, linux-x64-gnu, linux-x64-musl, wasm32-wasi, win32-arm64-msvc, win32-ia32-msvc, win32-x64-msvc) to 2.0.0-beta.4.
    • Updated @rspack/cli and @rspack/core to 2.0.0-beta.4.
    • Adjusted peer dependency ranges for @rspack/cli and @rspack/core.
  • src/server.ts
    • Refactored require.resolve calls for SockJSClient and WebSocketClient to be single-line for improved readability.
    • Refactored require.resolve call for ansi-html-community to be single-line for improved readability.
  • tests/e2e/snapshots/built-in-routes.test.js.snap
    • Updated content-type expectation for magic async chunk responses from application/javascript to text/javascript.
  • tests/e2e/snapshots/client-reconnect.test.js.snap
    • Updated client reconnect message expectation from JSHandle@object to [object Event].
  • tests/e2e/client.test.js
    • Refactored require.resolve calls within getClientEntry and getClientHotEntry methods for better readability.
    • Refactored require.resolve calls for webSocketTransport options in test cases for better readability.
  • tests/e2e/range-header.test.js
    • Added a new regular expression JAVASCRIPT_CONTENT_TYPE_RE to match both application/javascript and text/javascript content types.
    • Updated content-type assertions to use the new JAVASCRIPT_CONTENT_TYPE_RE regex instead of a strict string match.
  • tests/e2e/server-and-client-transport.test.js
    • Refactored require.resolve call for webSocketTransport option to be single-line for improved readability.
  • tests/normalizeOptions.test.ts
    • Refactored require.resolve call for webSocketTransport option to be single-line for improved readability.
Activity
  • The pull request was initiated to address and fix failed CI builds, which occurred after previous dependency updates.
  • The author, chenjiahan, updated the project to use @rspack/cli and @rspack/core version 2.0.0-beta.4.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates @rspack/cli and @rspack/core to a beta version to fix a failing CI pipeline. The changes primarily involve dependency updates in package.json and pnpm-lock.yaml, along with corresponding adjustments to test snapshots and configurations. A minor regression was noted where JavaScript files are now served with an obsolete MIME type. Overall, the changes are consistent with the PR's objective.

Comment thread tests/e2e/__snapshots__/built-in-routes.test.js.snap
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes failing CI by upgrading @rspack/core and @rspack/cli from the canary release 2.0.0-canary-20260116 to the stable beta 2.0.0-beta.4. It also updates test expectations to match behavioral changes introduced in the new version (content-type header values and WebSocket event serialization), and updates the Renovate configuration to prevent future automated upgrades of these packages.

Changes:

  • Upgrade @rspack/core and @rspack/cli from 2.0.0-canary-20260116 to 2.0.0-beta.4 across all package files and the lock file.
  • Update test assertions and snapshots to align with the new rspack version's output (e.g., text/javascript vs application/javascript, [object Event] vs JSHandle@object).
  • Migrate Renovate config from renovate.json5 to renovate.json and add ignoreDeps for the rspack packages to prevent accidental automated upgrades.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Bumps @rspack/core dev dependency to 2.0.0-beta.4
example/package.json Bumps @rspack/cli and @rspack/core to 2.0.0-beta.4
pnpm-lock.yaml Updates all resolved package entries from canary to 2.0.0-beta.4
tests/e2e/range-header.test.js Replaces exact content-type string assertions with a flexible regex to accommodate application/javascript or text/javascript
tests/e2e/__snapshots__/built-in-routes.test.js.snap Updates snapshots to reflect the new text/javascript content-type from rspack 2.0.0-beta.4
tests/e2e/__snapshots__/client-reconnect.test.js.snap Updates snapshot from JSHandle@object to [object Event] to match changed Puppeteer/rspack behavior
tests/e2e/client.test.js Cosmetic reformatting of multi-line require.resolve() calls
tests/e2e/server-and-client-transport.test.js Cosmetic reformatting of multi-line require.resolve() call
tests/normalizeOptions.test.ts Cosmetic reformatting of multi-line require.resolve() call
src/server.ts Cosmetic reformatting of multi-line require.resolve() calls
.github/renovate.json5 Deleted; replaced by renovate.json
.github/renovate.json New Renovate config in JSON format with ignoreDeps for rspack packages
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan merged commit 3a321d3 into main Mar 3, 2026
7 checks passed
@chenjiahan chenjiahan deleted the fix_deps_0303 branch March 3, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants