chore: fix failed CI after updating deps#100
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on stabilizing the project's dependencies by upgrading Rspack packages to a beta version and refining the automated dependency management. It also includes necessary updates to test expectations and minor code formatting improvements to ensure the project remains robust and maintainable following these dependency changes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates @rspack/cli and @rspack/core to a beta version to fix a failing CI pipeline. The changes primarily involve dependency updates in package.json and pnpm-lock.yaml, along with corresponding adjustments to test snapshots and configurations. A minor regression was noted where JavaScript files are now served with an obsolete MIME type. Overall, the changes are consistent with the PR's objective.
There was a problem hiding this comment.
Pull request overview
This PR fixes failing CI by upgrading @rspack/core and @rspack/cli from the canary release 2.0.0-canary-20260116 to the stable beta 2.0.0-beta.4. It also updates test expectations to match behavioral changes introduced in the new version (content-type header values and WebSocket event serialization), and updates the Renovate configuration to prevent future automated upgrades of these packages.
Changes:
- Upgrade
@rspack/coreand@rspack/clifrom2.0.0-canary-20260116to2.0.0-beta.4across all package files and the lock file. - Update test assertions and snapshots to align with the new rspack version's output (e.g.,
text/javascriptvsapplication/javascript,[object Event]vsJSHandle@object). - Migrate Renovate config from
renovate.json5torenovate.jsonand addignoreDepsfor the rspack packages to prevent accidental automated upgrades.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Bumps @rspack/core dev dependency to 2.0.0-beta.4 |
example/package.json |
Bumps @rspack/cli and @rspack/core to 2.0.0-beta.4 |
pnpm-lock.yaml |
Updates all resolved package entries from canary to 2.0.0-beta.4 |
tests/e2e/range-header.test.js |
Replaces exact content-type string assertions with a flexible regex to accommodate application/javascript or text/javascript |
tests/e2e/__snapshots__/built-in-routes.test.js.snap |
Updates snapshots to reflect the new text/javascript content-type from rspack 2.0.0-beta.4 |
tests/e2e/__snapshots__/client-reconnect.test.js.snap |
Updates snapshot from JSHandle@object to [object Event] to match changed Puppeteer/rspack behavior |
tests/e2e/client.test.js |
Cosmetic reformatting of multi-line require.resolve() calls |
tests/e2e/server-and-client-transport.test.js |
Cosmetic reformatting of multi-line require.resolve() call |
tests/normalizeOptions.test.ts |
Cosmetic reformatting of multi-line require.resolve() call |
src/server.ts |
Cosmetic reformatting of multi-line require.resolve() calls |
.github/renovate.json5 |
Deleted; replaced by renovate.json |
.github/renovate.json |
New Renovate config in JSON format with ignoreDeps for rspack packages |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updates the project to use
@rspack/cliand@rspack/coreversion2.0.0-beta.4instead of the previous canary release. It also updates the Renovate configuration and corrects a couple of test expectations.