Skip to content

chore: migrate fs.rmdirSync to fs.rmSync#105

Merged
chenjiahan merged 1 commit into
rstackjs:mainfrom
Gehbt:patch-1
Mar 3, 2026
Merged

chore: migrate fs.rmdirSync to fs.rmSync#105
chenjiahan merged 1 commit into
rstackjs:mainfrom
Gehbt:patch-1

Conversation

@Gehbt
Copy link
Copy Markdown
Contributor

@Gehbt Gehbt commented Mar 3, 2026

fs.rmDirSync(path, { recursive: true }) will throw Error in new version(v25).

Relate: https://github.com/nodejs/node/blob/2f5e9ccc538cf0503846784cc6c4126831e485ab/lib/fs.js#L1152

Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses the deprecation of fs.rmdirSync in newer Node.js versions by migrating its usage to fs.rmSync. This change ensures that the code remains compatible with future Node.js releases and avoids potential errors related to directory removal.

Highlights

  • fs.rmdirSync Deprecation: The fs.rmdirSync function is being deprecated in newer versions of Node.js (v25+).
  • Migration to fs.rmSync: This PR migrates the usage of fs.rmdirSync to fs.rmSync to avoid errors in newer Node.js versions.
  • Recursive Removal: The recursive: true option is used with both functions to ensure proper removal of directories and their contents.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • scripts/build-client-modules.cjs
    • Migrated from fs.rmdirSync to fs.rmSync to ensure compatibility with newer Node.js versions.
Activity
  • The PR addresses an issue where fs.rmdirSync throws an error in Node.js v25 and later.
  • The change involves replacing fs.rmdirSync(modulesDir, { recursive: true }) with fs.rmSync(modulesDir, { recursive: true }).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly migrates from the deprecated fs.rmdirSync to fs.rmSync to maintain compatibility with newer Node.js versions. I've suggested a small improvement to further simplify the code by using the force: true option, which removes the need for an explicit existence check before deleting the directory.

Comment thread scripts/build-client-modules.cjs
@chenjiahan chenjiahan merged commit ed00dfd into rstackjs:main Mar 3, 2026
3 checks passed
@Gehbt Gehbt deleted the patch-1 branch March 4, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants