Skip to content

feat!: rename webpack env vars to rspack#108

Merged
chenjiahan merged 1 commit into
mainfrom
update_env_0303
Mar 3, 2026
Merged

feat!: rename webpack env vars to rspack#108
chenjiahan merged 1 commit into
mainfrom
update_env_0303

Conversation

@chenjiahan
Copy link
Copy Markdown
Member

Update environment variable names from WEBPACK_DEV_SERVER_* to RSPACK_DEV_SERVER_* to align with the project's naming convention

Copilot AI review requested due to automatic review settings March 3, 2026 06:42
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant refactoring of environment variable names within the project. The change ensures that all relevant environment variables now use the RSPACK_DEV_SERVER_* prefix, replacing the older WEBPACK_DEV_SERVER_* convention. This update is crucial for maintaining consistency and clarity as the project transitions or solidifies its identity around Rspack, impacting how base ports and port retry mechanisms are configured and tested.

Highlights

  • Environment Variable Renaming: Updated all instances of WEBPACK_DEV_SERVER_* environment variables to RSPACK_DEV_SERVER_* to align with the project's new naming convention.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/server.ts
    • Renamed WEBPACK_DEV_SERVER_BASE_PORT to RSPACK_DEV_SERVER_BASE_PORT for base port configuration.
    • Renamed WEBPACK_DEV_SERVER_PORT_RETRY to RSPACK_DEV_SERVER_PORT_RETRY for port retry logic.
  • tests/e2e/api.test.js
    • Updated WEBPACK_DEV_SERVER_BASE_PORT and WEBPACK_DEV_SERVER_PORT_RETRY to their RSPACK_DEV_SERVER_* equivalents in afterEach hooks.
    • Modified WEBPACK_DEV_SERVER_BASE_PORT to RSPACK_DEV_SERVER_BASE_PORT in createDummyServers function.
    • Adjusted WEBPACK_DEV_SERVER_PORT_RETRY to RSPACK_DEV_SERVER_PORT_RETRY in multiple test cases related to port handling and retry logic.
  • tests/e2e/host.test.js
    • Replaced WEBPACK_DEV_SERVER_BASE_PORT with RSPACK_DEV_SERVER_BASE_PORT in host-related tests for auto port configuration.
    • Updated WEBPACK_DEV_SERVER_BASE_PORT to RSPACK_DEV_SERVER_BASE_PORT in the finally block of host tests.
  • tests/e2e/port.test.js
    • Changed WEBPACK_DEV_SERVER_BASE_PORT to RSPACK_DEV_SERVER_BASE_PORT in beforeEach and afterEach blocks for port configuration tests.
  • tests/e2e/web-socket-server-url.test.js
    • Renamed WEBPACK_DEV_SERVER_BASE_PORT to RSPACK_DEV_SERVER_BASE_PORT in various web socket server URL tests, including those for proxy and auto port scenarios.
    • Updated WEBPACK_DEV_SERVER_BASE_PORT to RSPACK_DEV_SERVER_BASE_PORT in finally blocks of web socket server URL tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully renames the WEBPACK_DEV_SERVER_* environment variables to RSPACK_DEV_SERVER_* across the codebase, aligning with the project's new naming convention. The changes are consistently applied in both the server logic and the e2e tests. However, there are opportunities to improve the robustness of environment variable parsing.

Comment thread src/server.ts
Comment thread src/server.ts
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the dev-server environment variable names from the legacy WEBPACK_DEV_SERVER_* prefix to the RSPACK_DEV_SERVER_* prefix, aligning runtime configuration with the project’s Rspack naming.

Changes:

  • Renamed WEBPACK_DEV_SERVER_BASE_PORTRSPACK_DEV_SERVER_BASE_PORT in server logic and e2e tests.
  • Renamed WEBPACK_DEV_SERVER_PORT_RETRYRSPACK_DEV_SERVER_PORT_RETRY in server logic and e2e tests.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/e2e/web-socket-server-url.test.js Updates env var used by websocket URL e2e scenarios to the new RSPACK_* name.
tests/e2e/port.test.js Updates env var used by port-selection e2e coverage to the new RSPACK_* name.
tests/e2e/host.test.js Updates env var used by host/auto-port e2e coverage to the new RSPACK_* name.
tests/e2e/api.test.js Updates env vars used by Server.getFreePort API e2e coverage to the new RSPACK_* names.
src/server.ts Switches runtime env var reads to RSPACK_DEV_SERVER_BASE_PORT and RSPACK_DEV_SERVER_PORT_RETRY.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/e2e/port.test.js
@chenjiahan chenjiahan merged commit deb9394 into main Mar 3, 2026
7 checks passed
@chenjiahan chenjiahan deleted the update_env_0303 branch March 3, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants