feat!: rename webpack env vars to rspack#108
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring of environment variable names within the project. The change ensures that all relevant environment variables now use the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully renames the WEBPACK_DEV_SERVER_* environment variables to RSPACK_DEV_SERVER_* across the codebase, aligning with the project's new naming convention. The changes are consistently applied in both the server logic and the e2e tests. However, there are opportunities to improve the robustness of environment variable parsing.
There was a problem hiding this comment.
Pull request overview
This PR updates the dev-server environment variable names from the legacy WEBPACK_DEV_SERVER_* prefix to the RSPACK_DEV_SERVER_* prefix, aligning runtime configuration with the project’s Rspack naming.
Changes:
- Renamed
WEBPACK_DEV_SERVER_BASE_PORT→RSPACK_DEV_SERVER_BASE_PORTin server logic and e2e tests. - Renamed
WEBPACK_DEV_SERVER_PORT_RETRY→RSPACK_DEV_SERVER_PORT_RETRYin server logic and e2e tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/web-socket-server-url.test.js | Updates env var used by websocket URL e2e scenarios to the new RSPACK_* name. |
| tests/e2e/port.test.js | Updates env var used by port-selection e2e coverage to the new RSPACK_* name. |
| tests/e2e/host.test.js | Updates env var used by host/auto-port e2e coverage to the new RSPACK_* name. |
| tests/e2e/api.test.js | Updates env vars used by Server.getFreePort API e2e coverage to the new RSPACK_* names. |
| src/server.ts | Switches runtime env var reads to RSPACK_DEV_SERVER_BASE_PORT and RSPACK_DEV_SERVER_PORT_RETRY. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update environment variable names from WEBPACK_DEV_SERVER_* to RSPACK_DEV_SERVER_* to align with the project's naming convention