test: remove wait-for-expect dependency and refactor tests

[chenjiahan]

Replace wait-for-expect with native Rstest polling in e2e tests.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's testing infrastructure by eliminating an external dependency and adopting a more integrated approach for asynchronous test assertions. By switching from wait-for-expect to Rspack's native polling mechanism, the codebase becomes leaner and potentially more aligned with the testing framework's capabilities, improving maintainability and reducing external package overhead.

Highlights

• Dependency Removal: The wait-for-expect dependency has been removed from the project's devDependencies and its lockfile.
• Test Refactoring: End-to-end tests in overlay.test.js have been refactored to replace wait-for-expect calls with native Rspack polling using expect.poll.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• package.json
  • Removed wait-for-expect from devDependencies.
• pnpm-lock.yaml
  • Removed wait-for-expect dependency entry from importers section.
  • Removed wait-for-expect package details from packages section.
  • Removed wait-for-expect entry from snapshots section.
• tests/e2e/overlay.test.js
  • Removed the wait-for-expect import statement.
  • Replaced waitForExpect usage with expect.poll for page HTML evaluation.
  • Replaced waitForExpect usage with expect.poll for mock callback assertion.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully removes the wait-for-expect dependency and refactors the e2e tests to use rstest's native polling feature. The changes in tests/e2e/overlay.test.js are mostly good, replacing waitForExpect with the more explicit expect.poll. However, I've found one instance where the new polling mechanism is overly complex and could be simplified for better readability and maintainability.

[Copilot]

Pull request overview

This PR replaces the wait-for-expect dependency with @rstest/core’s native expect.poll in the overlay end-to-end tests, simplifying the test stack and reducing external dependencies.

Changes:

• Removed wait-for-expect usage in tests/e2e/overlay.test.js and replaced it with expect.poll.
• Dropped wait-for-expect from package.json and cleaned it out of pnpm-lock.yaml.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/e2e/overlay.test.js	Replaces wait-for-expect retry loops with expect.poll polling for e2e assertions/state stabilization.
package.json	Removes wait-for-expect from devDependencies.
pnpm-lock.yaml	Removes wait-for-expect from the lockfile (importer + package/snapshot entries).

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.