Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the build/package setup so more runtime libraries are bundled into the published server build, and TypeScript declarations are generated as a bundled/rolled-up .d.ts output.
Changes:
- Add an explicit chunk name for the dynamic
chokidarimport to stabilize bundling output. - Switch the server
dtsconfiguration to a bundled declarations mode and configurewsenv defines to avoid optional native deps. - Move previously runtime-declared deps (
chokidar,connect-next,ws,@types/ws) out ofdependencies(now installed for build viadevDependencies) and update the lockfile accordingly.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/server.ts | Names the chokidar dynamic import chunk to align with existing dynamic-import bundling patterns. |
| rslib.config.ts | Enables d.ts bundling for the server build and sets ws define flags to avoid optional native dependencies during bundling. |
| package.json | Removes bundled libraries from dependencies, adds @microsoft/api-extractor, and keeps build-time deps in devDependencies. |
| pnpm-lock.yaml | Reflects dependency graph changes from the packaging/build adjustments. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.