test: replace supertest with custom http request helper

[chenjiahan]

Removes the supertest testing dependency and all its related transitive dependencies from the project, replacing its usage in tests with a custom HTTP request helper.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to streamline the project's testing infrastructure by eliminating the external supertest dependency. By replacing it with a custom HTTP request helper, the project reduces its reliance on third-party packages, potentially improving build times and offering more fine-grained control over test requests. This change primarily impacts the testing suite, ensuring that HTTP-related tests are now handled internally.

Highlights

• Dependency Removal: The supertest testing dependency and all its associated transitive dependencies have been removed from the project, significantly reducing the overall dependency footprint.
• Custom HTTP Request Helper: A new custom HTTP request helper module (tests/helpers/http-request.js) has been introduced to replace the functionality previously provided by supertest.
• Test Refactoring: Existing end-to-end tests that relied on supertest have been updated to utilize the newly created custom HTTP request helper, ensuring continued test coverage with the new approach.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• package.json
  • Removed 'supertest' from devDependencies.
• pnpm-lock.yaml
  • Removed 'supertest' and its transitive dependencies including 'asap', 'asynckit', 'combined-stream', 'component-emitter', 'cookiejar', 'delayed-stream', 'dezalgo', 'fast-safe-stringify', 'form-data', 'formidable', 'hexoid', 'mime', and 'superagent'.
• tests/e2e/client.test.js
  • Refactored 'require.resolve' calls for client entry points to improve readability.
• tests/e2e/headers.test.js
  • Replaced 'supertest' import with the custom 'http-request' helper.
  • Updated test calls to use the new 'request' helper, removing direct 'supertest' specific methods.
• tests/e2e/range-header.test.js
  • Replaced 'supertest' import with the custom 'http-request' helper.
  • Updated test calls to use the new 'request' helper, including handling 'Range' headers.
• tests/e2e/server-and-client-transport.test.js
  • Refactored 'require.resolve' call for WebSocket transport to improve readability.
• tests/e2e/server.test.js
  • Replaced 'supertest' import with the custom 'http-request' helper.
  • Updated test calls to use the new 'request' helper, removing direct 'supertest' specific methods and the 'req' variable.
• tests/helpers/http-request.js
  • Added a new helper module that provides a custom function for making HTTP requests, supporting both direct server app and port-based requests.
• tests/normalizeOptions.test.ts
  • Refactored 'require.resolve' call for WebSocket transport to improve readability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

This PR removes the supertest dependency from the test suite and replaces its usage with a lightweight in-repo HTTP request helper to reduce dependency and transitive dependency footprint.

Changes:

• Added a custom Node http/https request helper for tests (tests/helpers/http-request.js).
• Replaced supertest usage in affected e2e tests with the new helper.
• Removed supertest from package.json and updated pnpm-lock.yaml accordingly.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/normalizeOptions.test.ts	Minor formatting adjustment (no behavior change).
tests/helpers/http-request.js	Introduces a custom HTTP(S) request helper to replace supertest in tests.
tests/e2e/server.test.js	Switches requestCert-related test request from supertest to the new helper.
tests/e2e/server-and-client-transport.test.js	Minor formatting adjustment (no behavior change).
tests/e2e/range-header.test.js	Replaces supertest-based range/HEAD requests with the new helper.
tests/e2e/headers.test.js	Replaces supertest usage with the new helper for HEAD verification.
tests/e2e/client.test.js	Minor formatting adjustment (no behavior change).
package.json	Removes the supertest dev dependency.
pnpm-lock.yaml	Removes supertest and its transitive dependency entries from the lockfile.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request successfully removes the supertest dependency and replaces its usage with a custom HTTP request helper, which is a great simplification. The new helper in tests/helpers/http-request.js is well-structured. I've suggested a refactoring for the requestByApp function to improve its readability and error handling robustness by using async/await and a try...finally block. Overall, this is a solid improvement.