Skip to content

test: replace supertest with custom http request helper #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
Mar 3, 2026
Merged

test: replace supertest with custom http request helper #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4483a9b
test: replace supertest with custom http request helper
chenjiahan Mar 3, 2026
c178991
Merge branch 'main' into test_helper_0303
chenjiahan Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"simple-git-hooks": "^2.13.1",
"sockjs-client": "^1.6.1",
"style-loader": "^4.0.0",
"supertest": "^6.3.4",
"typescript": "^5.9.3",
"wait-for-expect": "^3.0.2",
"webpack": "^5.105.3",
Expand Down
116 changes: 0 additions & 116 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions tests/e2e/headers.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const request = require('supertest');
const { rspack } = require('@rspack/core');
const { RspackDevServer: Server } = require('@rspack/dev-server');
const config = require('../fixtures/simple-config/webpack.config');
const runBrowser = require('../helpers/run-browser');
const request = require('../helpers/http-request');
const port = require('../helpers/ports-map')['headers-option'];

describe('headers option', () => {
Expand Down Expand Up @@ -398,8 +398,6 @@ describe('headers option', () => {
let browser;
let pageErrors;
let consoleMessages;
let req;

beforeEach(async () => {
compiler = rspack(config);

Expand All @@ -413,8 +411,6 @@ describe('headers option', () => {

await server.start();

req = request(server.app);

({ page, browser } = await runBrowser());

pageErrors = [];
Expand Down Expand Up @@ -448,7 +444,11 @@ describe('headers option', () => {
);
expect(pageErrors).toMatchSnapshot('page errors');

const responseForHead = await req.get('/');
const responseForHead = await request({
port,
path: '/',
method: 'HEAD',
});

expect(responseForHead.headers['x-foo']).toBe('dev-server headers');
});
Expand Down
Loading