chore: add Rslint#16
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58c3c5436a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR migrates the repo’s JavaScript/TypeScript linting setup from ESLint to Rslint, updating configuration, dependencies, and CI so linting runs via pnpm run lint.
Changes:
- Replace ESLint config/ignore/tsconfig files with a new
rslint.config.ts. - Update
package.jsonscripts and devDependencies to use@rslint/coreand remove ESLint/Husky/lint-staged related tooling. - Update CI validation workflow and add a VS Code extension recommendation for Rslint.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.eslint.json | Removed ESLint-specific TS project config. |
| test/.eslintrc.js | Removed test-local ESLint rule overrides. |
| rslint.config.ts | Added Rslint configuration and rule override for historical any usage. |
| pnpm-lock.yaml | Updated lockfile for Rslint dependency set and removal of ESLint-related deps. |
| package.json | Switched lint scripts/deps to Rslint; removed ESLint/Husky/lint-staged configs. |
| .vscode/extensions.json | Recommend Rslint + Prettier VS Code extensions. |
| .husky/pre-commit | Removed pre-commit hook that ran lint-staged. |
| .github/workflows/validate.yml | CI now runs pnpm run lint instead of pnpm lint:js. |
| .eslintrc.js | Removed root ESLint configuration. |
| .eslintignore | Removed ESLint ignore file. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
N/A
Description
This PR replaces the repository ESLint lint entrypoint with Rslint. It adds
rslint.config.ts, the@rslint/coredev dependency, a VS Code extension recommendation, and updates validation CI to runpnpm run lint. Historicalanyusage is left in place with a targeted Rslint rule override.