Skip to content

chore: add Rslint#16

Merged
chenjiahan merged 3 commits into
masterfrom
chore/add-rslint
May 7, 2026
Merged

chore: add Rslint#16
chenjiahan merged 3 commits into
masterfrom
chore/add-rslint

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

N/A

Description

This PR replaces the repository ESLint lint entrypoint with Rslint. It adds rslint.config.ts, the @rslint/core dev dependency, a VS Code extension recommendation, and updates validation CI to run pnpm run lint. Historical any usage is left in place with a targeted Rslint rule override.

Copilot AI review requested due to automatic review settings May 7, 2026 13:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58c3c5436a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rslint.config.ts

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the repo’s JavaScript/TypeScript linting setup from ESLint to Rslint, updating configuration, dependencies, and CI so linting runs via pnpm run lint.

Changes:

  • Replace ESLint config/ignore/tsconfig files with a new rslint.config.ts.
  • Update package.json scripts and devDependencies to use @rslint/core and remove ESLint/Husky/lint-staged related tooling.
  • Update CI validation workflow and add a VS Code extension recommendation for Rslint.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tsconfig.eslint.json Removed ESLint-specific TS project config.
test/.eslintrc.js Removed test-local ESLint rule overrides.
rslint.config.ts Added Rslint configuration and rule override for historical any usage.
pnpm-lock.yaml Updated lockfile for Rslint dependency set and removal of ESLint-related deps.
package.json Switched lint scripts/deps to Rslint; removed ESLint/Husky/lint-staged configs.
.vscode/extensions.json Recommend Rslint + Prettier VS Code extensions.
.husky/pre-commit Removed pre-commit hook that ran lint-staged.
.github/workflows/validate.yml CI now runs pnpm run lint instead of pnpm lint:js.
.eslintrc.js Removed root ESLint configuration.
.eslintignore Removed ESLint ignore file.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
@chenjiahan chenjiahan merged commit 58bff63 into master May 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants