Skip to content

Commit 7f8c2ac

Browse files
chenjiahanCopilot
andauthored
refactor!: remove CommonJS and default export entrypoints (#90)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 541eee0 commit 7f8c2ac

File tree

15 files changed

+26
-143
lines changed

15 files changed

+26
-143
lines changed

README.md

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,17 +26,8 @@ bun add @rspack/plugin-react-refresh react-refresh -D
2626

2727
Import the plugin in your code:
2828

29-
- ES modules:
30-
31-
```js
32-
// Named import (recommended)
33-
import { ReactRefreshRspackPlugin } from "@rspack/plugin-react-refresh";
34-
```
35-
36-
- CommonJS:
37-
3829
```js
39-
const ReactRefreshRspackPlugin = require("@rspack/plugin-react-refresh");
30+
import { ReactRefreshRspackPlugin } from '@rspack/plugin-react-refresh';
4031
```
4132

4233
## Usage
@@ -47,27 +38,28 @@ Enabling [React Fast Refresh](https://reactnative.dev/docs/fast-refresh) functio
4738
- Code transformation can be added through loaders, such as [jsc.transform.react.refresh](https://swc.rs/docs/configuration/compilation#jsctransformreactrefresh) for [swc-loader](https://swc.rs/docs/usage/swc-loader) or the [react-refresh/babel](https://github.com/facebook/react/tree/main/packages/react-refresh) for [babel-loader](https://github.com/babel/babel-loader).
4839

4940
```js
50-
const ReactRefreshPlugin = require("@rspack/plugin-react-refresh");
51-
const isDev = process.env.NODE_ENV === "development";
41+
import { ReactRefreshRspackPlugin } from '@rspack/plugin-react-refresh';
42+
43+
const isDev = process.env.NODE_ENV === 'development';
5244

53-
module.exports = {
45+
export default {
5446
experiments: {
5547
rspackFuture: {
5648
disableTransformByDefault: true,
5749
},
5850
},
5951
// ...
60-
mode: isDev ? "development" : "production",
52+
mode: isDev ? 'development' : 'production',
6153
module: {
6254
rules: [
6355
{
6456
test: /\.jsx$/,
6557
use: {
66-
loader: "builtin:swc-loader",
58+
loader: 'builtin:swc-loader',
6759
options: {
6860
jsc: {
6961
parser: {
70-
syntax: "ecmascript",
62+
syntax: 'ecmascript',
7163
jsx: true,
7264
},
7365
transform: {
@@ -82,7 +74,7 @@ module.exports = {
8274
},
8375
],
8476
},
85-
plugins: [isDev && new ReactRefreshPlugin()].filter(Boolean),
77+
plugins: [isDev && new ReactRefreshRspackPlugin()].filter(Boolean),
8678
};
8779
```
8880

client/overlay/components/Spacer.js

Lines changed: 0 additions & 19 deletions
This file was deleted.

exports/index.cjs

Lines changed: 0 additions & 7 deletions
This file was deleted.

exports/index.d.cts

Lines changed: 0 additions & 3 deletions
This file was deleted.

exports/index.d.mts

Lines changed: 0 additions & 5 deletions
This file was deleted.

exports/index.mjs

Lines changed: 0 additions & 11 deletions
This file was deleted.

package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,12 @@
44
"repository": "https://github.com/rstackjs/rspack-plugin-react-refresh",
55
"license": "MIT",
66
"description": "React refresh plugin for Rspack",
7-
"main": "exports/index.cjs",
87
"type": "commonjs",
9-
"types": "exports/index.d.cts",
8+
"types": "./dist/index.d.ts",
109
"exports": {
1110
".": {
12-
"require": "./exports/index.cjs",
13-
"default": "./exports/index.mjs"
11+
"types": "./dist/index.d.ts",
12+
"default": "./dist/index.mjs"
1413
},
1514
"./react-refresh": "./client/reactRefresh.js",
1615
"./react-refresh-entry": "./client/reactRefreshEntry.js",
@@ -26,7 +25,7 @@
2625
"release": "node ./scripts/release.mjs",
2726
"bump": "npx bumpp --no-push --no-tag --no-commit"
2827
},
29-
"files": ["client", "dist", "exports"],
28+
"files": ["client", "dist"],
3029
"simple-git-hooks": {
3130
"pre-commit": "npx nano-staged"
3231
},

rslib.config.mts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
11
import { defineConfig } from '@rslib/core';
22

33
export default defineConfig({
4-
lib: [
5-
{
6-
format: 'cjs',
7-
bundle: true,
8-
dts: true,
9-
source: {
10-
tsconfigPath: './tsconfig.build.json',
11-
},
12-
},
13-
],
4+
lib: [{ bundle: true, dts: true }],
145
});

src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,3 @@ class ReactRefreshRspackPlugin {
109109
}
110110

111111
export { ReactRefreshRspackPlugin };
112-
export default ReactRefreshRspackPlugin;

test/exports-default-fallback.spec.mts

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)