feat: add .pnp.cjs to file dependencies on PnP load#193
Merged
Conversation
When Yarn PnP is enabled and the .pnp.cjs manifest is successfully loaded, record its path in the resolve context's file_dependencies. This allows build tools to watch the manifest for changes and invalidate cached resolutions accordingly.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Yarn Plug’n’Play (PnP) resolution tracking by ensuring the loaded .pnp.cjs manifest path is recorded in ResolveContext.file_dependencies, including when the manifest is reused from the resolver’s internal cache.
Changes:
- Cache the PnP manifest together with its filesystem path (
(PathBuf, pnp::Manifest)) so the path is available on subsequent cached lookups. - Add the
.pnp.cjsmanifest path toResolveContext.file_dependencieswhen PnP is used during resolution. - Add a regression test verifying
.pnp.cjsappears in file dependencies after resolving a PnP package.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib.rs | Store manifest path alongside manifest and record .pnp.cjs as a file dependency during PnP resolution. |
| src/tests/pnp.rs | Add pnp_file_dependencies test covering .pnp.cjs dependency recording via resolve_with_context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SyMind
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pnp.cjsis successfully loaded, record its path inResolveContext.file_dependencies(PathBuf, pnp::Manifest)tuple) so the path is available on subsequent cached lookupspnp_file_dependenciesverifying.pnp.cjsappears in file dependencies after resolving a PnP packageTest plan
cargo test pnp— all 8 PnP tests passcargo test— full test suite passes (130 tests)