codex: use camino for UTF-8 path assertions#220
Draft
hardfist wants to merge 2 commits into
Draft
Conversation
9e93be2 to
ccc0343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
caminoand introducespath_to_utf8(&Path) -> &Utf8Pathas the central UTF-8 path assertion helper.Utf8Path::as_str().std::pathfor now, so this stacked PR avoids a breaking API migration.Why
This builds on #219 by making the UTF-8-only path invariant explicit with a dedicated UTF-8 path type instead of ad hoc
Path::to_str()assertions.Scope
This is intentionally a low-risk first camino step. It does not migrate public
PathBuf/PathAPI types, filesystem traits, errors, or option structs toUtf8PathBufyet. Those can be handled in follow-up PRs if we want a full public API migration.Validation
cargo fmt --all --checkcargo check --workspacecargo clippy --all-features -- -D warningscargo test -p rspack_resolver --lib -- --skip pnp