Skip to content

Commit 402b2da

Browse files
fi3eworkclaude
andcommitted
fix(ci): align rspack execute-all workflows with other stacks
The execute-all matrix in from-pr and from-commit workflows was passing --suite-${suiteRefType} ${suiteRef}, which cac parsed in a way that left [...suites] empty, causing getSuitesToRun to fall back to running every available suite alphabetically. Each matrix shard then ran unrelated suites until one failed. Drop the suite-ref args in execute-all so rspack matches rsbuild/rslib/ rstest/rsdoctor/rspress, where execute-all only forwards the matrix suite name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent f6ea537 commit 402b2da

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

.github/workflows/rspack-ecosystem-ci-from-commit.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,13 +224,11 @@ jobs:
224224
run-suites
225225
--stack rspack
226226
--release "$(node -p "require('./workspace/rspack/packages/rspack/package.json').version")"
227-
--suite-${{ inputs.suiteRefType }} ${{ inputs.suiteRef }}
228227
${{ matrix.suite }}
229228
- name: Run suite (selftest)
230229
if: matrix.suite == '_selftest'
231230
run: >-
232231
pnpm tsx ecosystem-ci.ts
233232
run-suites
234233
--stack rspack
235-
--suite-${{ inputs.suiteRefType }} ${{ inputs.suiteRef }}
236234
${{ matrix.suite }}

.github/workflows/rspack-ecosystem-ci-from-pr.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,5 +175,4 @@ jobs:
175175
run-suites
176176
--stack rspack
177177
--release "$(node -p "require('./workspace/rspack/packages/rspack/package.json').version")"
178-
--suite-${{ inputs.suiteRefType }} ${{ inputs.suiteRef }}
179178
${{ matrix.suite }}

0 commit comments

Comments
 (0)