Skip to content

fix(ci): dispatch against main instead of deleted feature branch#67

Draft
stormslowly wants to merge 1 commit into
mainfrom
fix/dispatch-ref-main
Draft

fix(ci): dispatch against main instead of deleted feature branch#67
stormslowly wants to merge 1 commit into
mainfrom
fix/dispatch-ref-main

Conversation

@stormslowly

Copy link
Copy Markdown
Contributor

Why

#64 swapped the Docker trigger-workflow-and-wait for JS workflow_dispatch, but left the return-dispatch step in ecosystem_ci_dispatch pointing at its own feature branch:

ref: ci/dockerless-workflow-dispatch

That branch was deleted after #64 merged, so every from-PR dispatch now fails at the dispatch call:

##[error] dispatchWorkflow: No ref found for: ci/dockerless-workflow-dispatch
##[error] await-remote-run: Run ID must be provided.

continue-on-error: true masks it as a green job, and the PR only gets a cannot determine workflow run id comment — the downstream suites never run. (Reproduced via web-infra-dev/rspack#14726 → run 28925071792.)

ecosystem_ci_per_commit already uses ref: main; this aligns the dispatch variant.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This change updates the ecosystem_ci_dispatch GitHub Action configuration file to change the dispatched workflow ref from ci/dockerless-workflow-dispatch to main. No other changes were made to the dispatch inputs or subsequent steps.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the CI dispatch ref change from the deleted feature branch to main.
Description check ✅ Passed The description directly explains the dispatch failure and the ref change made in this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dispatch-ref-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/actions/ecosystem_ci_dispatch/action.yaml (1)

117-127: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Follow the SHA Pin Update Policy for ecosystem_ci_dispatch changes.

Per the coding guidelines for .github/actions/ecosystem_ci_dispatch/**, any change to this action requires bumping version in package.json, dispatching release.yml to cut a new tag, and then bumping the @<sha> pins in every upstream stack repo. This ref change modifies the action's behavior, so the full release and pin-update process should be completed as part of this PR.

As per coding guidelines: "For .github/actions/ecosystem_ci_dispatch/** or ecosystem_ci_per_commit/** changes, bump version in package.json, dispatch release.yml to cut a new tag, then bump the two @<sha> pins in every upstream stack repo."

🔍 Verification script
#!/bin/bash
# Check if package.json exists in this action directory and whether version was bumped
cat .github/actions/ecosystem_ci_dispatch/package.json 2>/dev/null || echo "package.json not found"

# Search for upstream SHA pins referencing this action
rg -rn 'ecosystem_ci_dispatch@' .github/ --glob '!**/ecosystem_ci_dispatch/**'
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/actions/ecosystem_ci_dispatch/action.yaml around lines 117 - 127,
The ref update in ecosystem_ci_dispatch changes action behavior, so complete the
release workflow for this action: bump the version in the action’s package.json,
dispatch release.yml to publish a new tag, and then update every upstream stack
repo to use the new @<sha> pin. Make sure the pin changes are applied wherever
ecosystem_ci_dispatch is referenced, using the action’s existing release/tagging
flow and the identified dispatch step to locate the change.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/actions/ecosystem_ci_dispatch/action.yaml:
- Line 120: The dispatch step in the ecosystem CI action is still configured to
ignore failures, which can leave the job green even when the workflow run ID is
missing. Remove the continue-on-error setting from the dispatch step, or add
explicit failure handling after the dispatch in the same action so the job fails
when steps.dispatch.outputs.run_id is empty. Use the existing dispatch step and
its run_id output as the location to wire in the failure check.

---

Outside diff comments:
In @.github/actions/ecosystem_ci_dispatch/action.yaml:
- Around line 117-127: The ref update in ecosystem_ci_dispatch changes action
behavior, so complete the release workflow for this action: bump the version in
the action’s package.json, dispatch release.yml to publish a new tag, and then
update every upstream stack repo to use the new @<sha> pin. Make sure the pin
changes are applied wherever ecosystem_ci_dispatch is referenced, using the
action’s existing release/tagging flow and the identified dispatch step to
locate the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 06f44490-0caa-4986-8de9-d07929090a37

📥 Commits

Reviewing files that changed from the base of the PR and between edf483f and e6587b7.

📒 Files selected for processing (1)
  • .github/actions/ecosystem_ci_dispatch/action.yaml

@@ -120,7 +120,7 @@ runs:
continue-on-error: true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

continue-on-error: true still masks dispatch failures.

The PR objectives note that continue-on-error: true previously masked the dispatch failure, causing a green job while only posting a cannot determine workflow run id comment. This PR fixes the root cause (wrong ref) but leaves continue-on-error: true in place, so any future dispatch failure will still be silently swallowed and report green. Consider removing continue-on-error: true from the dispatch step — or at minimum adding a follow-up step that fails the job when steps.dispatch.outputs.run_id is empty — so failures surface explicitly.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/actions/ecosystem_ci_dispatch/action.yaml at line 120, The dispatch
step in the ecosystem CI action is still configured to ignore failures, which
can leave the job green even when the workflow run ID is missing. Remove the
continue-on-error setting from the dispatch step, or add explicit failure
handling after the dispatch in the same action so the job fails when
steps.dispatch.outputs.run_id is empty. Use the existing dispatch step and its
run_id output as the location to wire in the failure check.

@stormslowly stormslowly marked this pull request as draft July 8, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant