From 8bb8e357249416d2935235c8c69a9beee40f9ae0 Mon Sep 17 00:00:00 2001 From: fi3ework Date: Wed, 1 Apr 2026 11:25:22 +0800 Subject: [PATCH 1/2] fix(ci): use pnpm exec for playwright install to match lockfile version `pnpm dlx playwright install` pulls the latest playwright CLI, which may download a different chromium revision than the one expected by the project's locked playwright version. This caused browser-related rstest examples to fail when the latest playwright (chromium v1217) diverged from the locked playwright@1.58.1 (chromium v1208). Switch to `pnpm exec playwright install --with-deps chromium` so the project's own playwright binary is used to download the matching browser. Amp-Thread-ID: https://ampcode.com/threads/T-019d4701-dfdb-73c6-a876-29ab299f63cf Co-authored-by: Amp --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b83f4f0b6..2960fbc35 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -32,7 +32,7 @@ jobs: run: pnpm install - name: Install Playwright browsers - run: pnpm dlx playwright install chromium + run: pnpm exec playwright install --with-deps chromium - name: Build Rspack run: | From 7664b0091953b0dc9e619151f2a858a02b4df3da Mon Sep 17 00:00:00 2001 From: fi3ework Date: Wed, 1 Apr 2026 11:27:46 +0800 Subject: [PATCH 2/2] fix(ci): scope playwright install to a package that has it as dependency Amp-Thread-ID: https://ampcode.com/threads/T-019d4701-dfdb-73c6-a876-29ab299f63cf Co-authored-by: Amp --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 2960fbc35..5d4d1359b 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -32,7 +32,7 @@ jobs: run: pnpm install - name: Install Playwright browsers - run: pnpm exec playwright install --with-deps chromium + run: pnpm --filter @rstest-example/browser-locator exec playwright install --with-deps chromium - name: Build Rspack run: |