-
Notifications
You must be signed in to change notification settings - Fork 44
chore: replace biome with prettier and rslint #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| coverage | ||
| compiled | ||
| dist | ||
| dist-* | ||
| doc_build | ||
| node_modules | ||
| .swc | ||
| **/coverage | ||
| **/compiled | ||
| **/dist | ||
| **/dist-* | ||
| **/doc_build | ||
| **/auto-imports.d.ts | ||
| **/components.d.ts | ||
| **/@mf-types/** | ||
| **/http-import.lock.data/** | ||
| **/__snapshots__/** |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "singleQuote": true, | ||
| "printWidth": 100, | ||
| "tabWidth": 2, | ||
| "useTabs": false, | ||
| "endOfLine": "lf" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| { | ||
| "recommendations": ["biomejs.biome"] | ||
| "recommendations": ["esbenp.prettier-vscode"] | ||
| } |
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -11,21 +11,30 @@ | |||||||||
| "build:rspack": "pnpm --filter \"@rspack-example/*\" --stream build", | ||||||||||
| "build:rspress": "pnpm --filter \"@rspress-example/*\" --stream build", | ||||||||||
| "bump": "taze -l", | ||||||||||
| "prepare": "husky", | ||||||||||
| "lint": "rslint && prettier -c .prettierrc .vscode/extensions.json .vscode/settings.json AGENTS.md package.json pnpm-lock.yaml rslint.config.ts", | ||||||||||
| "lint:write": "prettier -w .prettierrc .vscode/extensions.json .vscode/settings.json AGENTS.md package.json pnpm-lock.yaml rslint.config.ts", | ||||||||||
|
Comment on lines
+14
to
+15
|
||||||||||
| "lint": "rslint && prettier -c .prettierrc .vscode/extensions.json .vscode/settings.json AGENTS.md package.json pnpm-lock.yaml rslint.config.ts", | |
| "lint:write": "prettier -w .prettierrc .vscode/extensions.json .vscode/settings.json AGENTS.md package.json pnpm-lock.yaml rslint.config.ts", | |
| "lint": "rslint && prettier -c .", | |
| "lint:write": "prettier -w .", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says the remaining Biome-specific directives were updated, but there are still
// biome-ignoredirectives present in other tracked files (e.g.rsbuild/vue-auto-import/auto-imports.d.ts,rsbuild/vue-element-plus/auto-imports.d.ts,rsbuild/vue-element-plus/components.d.ts). Either update/remove those directives as well or clarify in the description that only a subset was migrated in this PR.