Accept python_version in product-release workflow#898
Merged
Conversation
Add an optional python_version input to product-release.yml. When
provided alongside product=connect, a new step writes the correct
/opt/python/{version}/bin/python path into the chart's values.yaml
before the PR is created. The NEWS entry and PR body are also updated
to surface the Python version.
Workbench and Package Manager dispatches are unaffected — the new
input is optional and the sync step guards on product == 'connect'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
product-release.ymlto accept an optionalpython_versioninput. When provided for a Connect release, a new step writes the correct Python executable path intocharts/rstudio-connect/values.yamlbefore the PR is created.Receiving end of posit-dev/images-connect#59, which passes the Python version from the images-connect production build.
python_versionis optional; Workbench and Package Manager dispatches are unaffectedproduct == 'connect' && python_version != ''