add support and tests for upload/version_delete

Author: isabelizimm

pins/boards.py

@@ -89,8 +89,10 @@ def pin_versions(self, name: str, as_df: bool = True) -> Sequence[VersionRaw]:
             Pin name.
 
         """
-        if self.versioned is False:
-            raise NotImplementedError()
+        if not self.versioned:
+            raise NotImplementedError(
+                "Cannot show versions for a board type that does not support versioning."
+            )
 
         if not self.pin_exists(name):
             raise PinsError("Cannot check version, since pin %s does not exist" % name)
@@ -236,6 +238,11 @@ def _pin_store(
         created: Optional[datetime] = None,
     ) -> Meta:
 
+        if not self.versioned:
+            raise NotImplementedError(
+                "Can only write pins with boards that support versioning."
+            )
+
         if type == "feather":
             warn_deprecated(
                 'Writing pin type "feather" is unsupported. Switching type to "arrow".'
@@ -453,6 +460,10 @@ def pin_version_delete(self, name: str, version: str):
         version:
             Version identifier.
         """
+        if not self.versioned:
+            raise NotImplementedError(
+                "Can only write pins with boards that support versioning."
+            )
 
         pin_name = self.path_to_pin(name)
 

pins/tests/test_constructors.py

@@ -73,7 +73,9 @@ def test_constructor_board_url_data(tmp_cache, http_example_board_path, df_csv):
 
 @pytest.mark.xfail
 @pytest.mark.skip_on_github
-def test_constructor_board_url_cache(tmp_cache, http_example_board_path, df_csv):
+def test_constructor_board_url_cache(
+    tmp_cache, http_example_board_path, df_csv, tmp_path
+):
     # TODO: downloading a pin does not put files in the same directory, since
     # in this case we are hashing on the full url.
 
@@ -85,12 +87,19 @@ def test_constructor_board_url_cache(tmp_cache, http_example_board_path, df_csv)
 
     board.pin_read("df_csv")
 
-    # cannot read or view pin versions
+    # cannot write or view pin versions
 
     with pytest.raises(NotImplementedError):
         board.pin_write(df_csv)
     with pytest.raises(NotImplementedError):
         board.pin_versions("df_csv")
+    with pytest.raises(NotImplementedError):
+        board.pin_version_delete(name="df_csv", version="20220214T163718Z")
+    with pytest.raises(NotImplementedError):
+        df = pd.DataFrame({"x": [1, 2, 3]})
+        path = tmp_path / "data.csv"
+        df.to_csv(path, index=False)
+        board.pin_upload(path, "cool_pin")
 
     # check cache ----
     http_dirs = list(tmp_cache.glob("http_*"))