Move calls to create_adapter to hide them at a lower level

Author: nathanjmcdougall

pins/_adaptors.py

@@ -148,5 +148,7 @@ def create_adaptor(obj: Any) -> Adaptor: ...
 def create_adaptor(obj: Any | DataFrame) -> Adaptor | DFAdaptor:
     if isinstance(obj, AbstractPandasFrame):
         return PandasAdaptor(obj)
+    elif isinstance(obj, Adaptor):
+        return obj
     else:
         return Adaptor(obj)

pins/boards.py

@@ -10,7 +10,7 @@
 from datetime import datetime, timedelta
 from io import IOBase
 from pathlib import Path
-from typing import Protocol
+from typing import Any, Protocol
 
 from importlib_resources import files
 from importlib_resources.abc import Traversable
@@ -697,8 +697,6 @@ def prepare_pin_version(
         created: datetime | None = None,
         object_name: str | list[str] | None = None,
     ):
-        x = create_adaptor(x)
-
         meta = self._create_meta(
             pin_dir_path,
             x,
@@ -720,7 +718,7 @@ def prepare_pin_version(
     def _create_meta(
         self,
         pin_dir_path,
-        x: Adaptor,
+        x: Adaptor | Any,
         name: str | None = None,
         type: str | None = None,
         title: str | None = None,
@@ -737,7 +735,7 @@ def _create_meta(
             raise NotImplementedError("Type argument is required.")
 
         if title is None:
-            title = x.default_title(name)
+            title = create_adaptor(x).default_title(name)
 
         # create metadata from object on disk ---------------------------------
         # save all pin data to a temporary folder (including data.txt), so we
@@ -1203,16 +1201,14 @@ def user_name(self):
         return self.fs.api.get_user()["username"]
 
     def prepare_pin_version(self, pin_dir_path, x, name: str | None, *args, **kwargs):
-        adaptor = create_adaptor(x)
-
         # RSC pin names can have form <user_name>/<name>, but this will try to
         # create the object in a directory named <user_name>. So we grab just
         # the <name> part.
         short_name = name.split("/")[-1]
 
         # TODO(compat): py pins always uses the short name, R pins uses w/e the
         # user passed, but guessing people want the long name?
-        meta = super()._create_meta(pin_dir_path, adaptor, short_name, *args, **kwargs)
+        meta = super()._create_meta(pin_dir_path, x, short_name, *args, **kwargs)
         meta.name = name
 
         # copy in files needed by index.html ----------------------------------
@@ -1238,7 +1234,7 @@ def prepare_pin_version(self, pin_dir_path, x, name: str | None, *args, **kwargs
             "pin_files": pin_files,
             "pin_metadata": meta,
             "board_deparse": board_deparse(self),
-            "data_preview": adaptor.data_preview,
+            "data_preview": create_adaptor(x).data_preview,
         }
 
         # do not show r code if not round-trip friendly