Rename action levels#611
Draft
yjunechoe wants to merge 39 commits intorstudio:mainfrom
Draft
Conversation
Collaborator
Author
|
Still working my way through this but just had a thought: Since the diffs are getting huge (due to find-and-replace), I think I'll revert those before I open this PR for review (which should only generate deprecation warnings in the checks), and then I can re-apply the name changes (which should resolve those deprecation warnings and put us back on track -- this can also be done in a separate PR to chunk things up). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A TODO list for renaming action levels:
User-facing functions:
action_levels()soft deprecation safeguardsaction_levels()documentationwarn_on_fail()error_on_fail(error)to deprecatestop_on_fail(stop_at)fns(nowfns = action_fns(warn, error, critical)Formalizing a<action_fns>object #612 )action_fns()(perhaps this PR can implement this internally and exporting can be separate PR)get_agent_x_list()rename$stop,$notifyDisplay/write:
<action_levels>prints using new namesget_agent_report()(report_tbl)get_multiagent_report()YAML:
Internals (low priority):
<action_levels>object (ex:$stop_fraction->$error_fraction)agent$validation_set(related toget_agent_x_list()output)Documentation:
action_levels()documentationFind-and-replace:
action_levels()should use new names (ex: in "::QUIET::" agents for test/expect functions)Tests:
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.