use_gazeboがtrueの時だけworldリンクを定義する#23
Open
YusukeKato wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
worldリンクはGazebo以外では不要なため、use_gazeboがtrueの時だけ定義するように修正します。
worldリンクが定義されているかどうかのテストも追加します。
Does this close any currently open issues?
しません。
How has this been tested?
display.launch.py実行時にworldリンクが定義されていないことを確認しました。
sciurus17_rosでMockComponentとGazeboでそれぞれ動作確認しました。
Any other comments?
sciurus17_rosのRVizの設定ファイルではfixed frameがworldに設定されているためbase_linkに変更する必要があります。
また、sciurus17.srdfのbase_link_to_world_jointが不要になるため削除したほうがよさそうです。
https://github.com/rt-net/sciurus17_ros/blob/ros2/sciurus17_moveit_config/config/sciurus17.srdf#L151
Checklists