Skip to content

Commit 8564b26

Browse files
committed
update for of loop with for each loop
1 parent b04b78b commit 8564b26

2 files changed

Lines changed: 8 additions & 24 deletions

File tree

frontend/packages/app/src/pages/project-details/tabs/risks/kanban/kanbanView.tsx

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,21 @@ export function RisksKanbanView() {
3434
(c) => c.actions.openCreateRiskWithStatus,
3535
);
3636
const toast = useToasts();
37-
const [localData, setLocalData] = useState<RiskItem[]>(data);
38-
39-
useEffect(() => {
40-
if (!data || data.length === 0) return;
41-
setLocalData(data);
42-
}, [data]);
4337

4438
const [items, setItems] = useState<RiskIdsByStatus>(emptyGroups);
4539

4640
const byId = useMemo(() => {
4741
const map = new Map<string, RiskItem>();
48-
for (const risk of localData) {
42+
for (const risk of data) {
4943
map.set(risk.name, risk);
5044
}
5145
return map;
52-
}, [localData]);
46+
}, [data]);
5347

5448
useEffect(() => {
55-
if (!localData) return;
56-
setItems(groupIdsByStatus(localData));
57-
}, [localData]);
49+
if (!data) return;
50+
setItems(groupIdsByStatus(data));
51+
}, [data]);
5852

5953
return (
6054
<DragDropProvider<RiskDragData, RiskDraggable, RiskDroppable>
@@ -78,7 +72,7 @@ export function RisksKanbanView() {
7872
try {
7973
await updateRiskStatus(riskId, newStatus);
8074
} catch {
81-
setItems(groupIdsByStatus(localData));
75+
setItems(groupIdsByStatus(data));
8276
const risk = byId.get(riskId);
8377
toast.error(
8478
`Error updating status for ${risk?.risk_category ?? riskId}`,

frontend/packages/app/src/pages/project-details/tabs/risks/list/listView.tsx

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,19 @@
11
/**
22
* External dependencies.
33
*/
4-
import { useEffect, useState } from "react";
54
import { Accordion } from "@base-ui/react/accordion";
65

76
/**
87
* Internal dependencies.
98
*/
109
import { useRisks } from "../context";
1110
import { RiskGroup } from "./listViewGroup";
12-
import { RiskItem } from "../types";
1311

1412
export function RisksListView() {
1513
const data = useRisks((c) => c.state.data);
16-
const [localData, setLocalData] = useState<RiskItem[]>(data);
1714

18-
useEffect(() => {
19-
if (!data || data.length === 0) return;
20-
setLocalData(data);
21-
}, [data]);
22-
23-
const openRisks = localData.filter(
24-
(r) => !r.status || r.status !== "Mitigated",
25-
);
26-
const mitigatedRisks = localData.filter((r) => r.status === "Mitigated");
15+
const openRisks = data.filter((r) => !r.status || r.status !== "Mitigated");
16+
const mitigatedRisks = data.filter((r) => r.status === "Mitigated");
2717

2818
return (
2919
<Accordion.Root multiple defaultValue={["open", "mitigated"]}>

0 commit comments

Comments
 (0)