Skip to content

Commit d1b813e

Browse files
committed
chore: improve sort button styles
1 parent 8564b26 commit d1b813e

1 file changed

Lines changed: 33 additions & 29 deletions

File tree

  • frontend/packages/design-system/src/components/sort-button

frontend/packages/design-system/src/components/sort-button/index.tsx

Lines changed: 33 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -63,38 +63,42 @@ export function SortButton({
6363
<Popover.Portal>
6464
<Popover.Positioner side="bottom" align="end" sideOffset={4}>
6565
<Popover.Popup className="min-w-44 rounded-lg border border-outline-gray-2 bg-surface-white shadow-lg py-1 z-50">
66-
{fields.map(({ field, label }) => {
67-
const isSelected = sort?.field === field;
68-
return (
69-
<button
70-
key={field}
71-
type="button"
72-
className="flex w-full items-center justify-between gap-3 px-3 py-1.5 text-sm text-ink-gray-8 hover:bg-surface-gray-2"
73-
onClick={() => handleFieldClick(field)}
74-
>
75-
<span>{label}</span>
76-
{isSelected &&
77-
(sort.order === "asc" ? (
78-
<ArrowUp className="size-4" />
79-
) : (
80-
<ArrowDown className="size-4" />
81-
))}
82-
</button>
83-
);
84-
})}
66+
<div className="flex flex-col px-1">
67+
{fields.map(({ field, label }) => {
68+
const isSelected = sort?.field === field;
69+
return (
70+
<button
71+
key={field}
72+
type="button"
73+
className="flex w-full items-center justify-between gap-3 px-3 py-1.5 rounded text-sm text-ink-gray-8 hover:bg-surface-gray-2"
74+
onClick={() => handleFieldClick(field)}
75+
>
76+
<span>{label}</span>
77+
{isSelected &&
78+
(sort.order === "asc" ? (
79+
<ArrowUp className="size-4" />
80+
) : (
81+
<ArrowDown className="size-4" />
82+
))}
83+
</button>
84+
);
85+
})}
86+
</div>
8587
{isActive && (
8688
<>
8789
<div className="my-1 border-t border-outline-gray-2" />
88-
<button
89-
type="button"
90-
className="flex w-full items-center px-3 py-1.5 text-sm text-ink-red-3 hover:bg-surface-gray-2"
91-
onClick={() => {
92-
onSortChange(null);
93-
setOpen(false);
94-
}}
95-
>
96-
Clear sort
97-
</button>
90+
<div className="px-1">
91+
<button
92+
type="button"
93+
className="flex w-full items-center px-3 py-1.5 rounded text-sm text-ink-red-3 hover:bg-surface-gray-2"
94+
onClick={() => {
95+
onSortChange(null);
96+
setOpen(false);
97+
}}
98+
>
99+
Clear sort
100+
</button>
101+
</div>
98102
</>
99103
)}
100104
</Popover.Popup>

0 commit comments

Comments
 (0)