fix: missing remote attachments issue

[Kallyan01]

What

Remote site post thumbnail issue on the search area.

Why

It's impacting search result functionality.

Related Issue(s):

Closes https://github.com/rtCamp/OnePress/issues/73

How

The thumbnails were not loading in the search results because remote posts were assigned negative post IDs. To address this, we intercepted those posts and generated the thumbnail data through filters, ensuring that thumbnails are displayed correctly in the search results.

AI Disclosure

Claude Opus 4.6 ( Research )

Testing Instructions

• Set up both the Governing and Brand sites in a local environment using wp-env.
• Upload a few media files to the Brand site and run the re-index process.
• On the Governing site, search for the uploaded media file names.
• Verify that the media results now display visible thumbnails, whereas previously the thumbnails were not appearing.

Screenshots

Before:

After:

Additional Info

Checklist

• I have read the Contribution Guidelines.
• I have read the Development Guidelines.
• I have added necessary tests to cover my changes.
• I have updated the project documentation as needed.
• My code has detailed inline documentation.
• My code is tested to the best of my abilities.
• My code passes all lints, tests, and checks.

[Copilot]

Pull request overview

Fixes missing thumbnails for remote (Algolia-hydrated) attachment results in the search UI by carrying thumbnail metadata on mocked remote WP_Post objects and intercepting WordPress image/thumbnail rendering paths to use that metadata.

Changes:

• Adds remote thumbnail plumbing by storing Algolia thumbnail record data on remote WP_Post objects.
• Hooks into WordPress image/thumbnail/content rendering filters to output remote thumbnail URLs/HTML for negative-ID (remote) posts and attachments.
• Updates PHPStan stubs to model the new dynamic onesearch_thumbnail property.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
phpstan/stubs/wordpress-extended.php	Adds PHPStan typing for the new WP_Post::$onesearch_thumbnail dynamic property.
inc/Modules/Search/Search.php	Adds filters + helper logic to render remote thumbnails correctly for search results containing remote/negative-ID posts.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[justlevine]

Ignore the copilot noise for now: this is what I was concerned about:

(Left is the local post, right is the remote)

It's possible that the preg_replace can be fixed to better support other block image attachments, and even switching to the more ideal HTML API could catch even more. But ultimately the use of replacing the image output is always going to be flawed, fragile, and susceptible to edge cases.

As mentioned both in the GH issue and on slack, unless you have a reason otherwise, I think the best way to address the bug will be to:

1. Programmatically create a single fictitious attachment at plugin activation (and checking/recreating it when using) and assign that number as the post attachment id instead of a non-existent negative post id. It should be hidden from the UX.
2. Use the attachment hooks to swap out the metadata on the attachment to the specific remote file, instead of trying to finagle the post directly.

This way any attachment-related functionality work natively the image routing is an isolated implementation detail.

[codecov-commenter]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[Kallyan01]

@justlevine, the issue with the current fix isn't clear to me. Could you please help me if I'm missing any details or edge cases? All I can see is a missing publish date and a bit smaller thumbnail size.

Source Site Result

Remote Site Result

[justlevine]

@justlevine, the issue with the current fix isn't clear to me. Could you please help me if I'm missing any details or edge cases? All I can see is a missing publish date and a bit smaller thumbnail size.

Inspect the actual html for both. Different blocks (and settings) render images differently with different html attributes and patterns. Your search-replace ditches all of that for a specific <img > , and trying to manually enumerate the specific blocks as conditionals means that we need to manually add support for every new block and anything the end-user has custom is SOL.

[justlevine]

Here's the dummy post from above that you can use for testing. Don't forget to update the images after you paste it in.

<!-- wp:paragraph -->
<p>image</p>
<!-- /wp:paragraph -->

<!-- wp:image {"id":7,"sizeSlug":"full","linkDestination":"none"} -->
<figure class="wp-block-image size-full"><img src="http://localhost:8888/wp-content/uploads/2026/06/900-536x354-1.jpg" alt="Some picsum for my testsum" class="wp-image-7"/><figcaption class="wp-element-caption">Picsum ID: 900</figcaption></figure>
<!-- /wp:image -->

<!-- wp:paragraph -->
<p>Gallery</p>
<!-- /wp:paragraph -->

<!-- wp:gallery {"linkTo":"none"} -->
<figure class="wp-block-gallery has-nested-images columns-default is-cropped"><!-- wp:image {"id":7,"sizeSlug":"large","linkDestination":"none"} -->
<figure class="wp-block-image size-large"><img src="http://localhost:8888/wp-content/uploads/2026/06/900-536x354-1.jpg" alt="Some picsum for my testsum" class="wp-image-7"/><figcaption class="wp-element-caption">Picsum ID: 900</figcaption></figure>
<!-- /wp:image --></figure>
<!-- /wp:gallery -->

<!-- wp:paragraph -->
<p>Media/Text</p>
<!-- /wp:paragraph -->

<!-- wp:media-text {"mediaId":7,"mediaLink":"http://localhost:8888/picsum-id-900/","linkDestination":"none","mediaType":"image"} -->
<div class="wp-block-media-text is-stacked-on-mobile"><figure class="wp-block-media-text__media"><img src="http://localhost:8888/wp-content/uploads/2026/06/900-536x354-1.jpg" alt="Some picsum for my testsum" class="wp-image-7 size-full"/></figure><div class="wp-block-media-text__content"><!-- wp:paragraph {"placeholder":"Content…"} -->
<p>Media text</p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:media-text -->

<!-- wp:cover {"url":"http://localhost:8888/wp-content/uploads/2026/06/900-536x354-1.jpg","id":7,"alt":"Some picsum for my testsum","dimRatio":50,"customOverlayColor":"#9b7861","isUserOverlayColor":false,"isDark":false,"sizeSlug":"full","layout":{"type":"constrained"}} -->
<div class="wp-block-cover is-light"><img class="wp-block-cover__image-background wp-image-7 size-full" alt="Some picsum for my testsum" src="http://localhost:8888/wp-content/uploads/2026/06/900-536x354-1.jpg" data-object-fit="cover"/><span aria-hidden="true" class="wp-block-cover__background has-background-dim" style="background-color:#9b7861"></span><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"placeholder":"Write title…","style":{"typography":{"textAlign":"center"}},"fontSize":"large"} -->
<p class="has-text-align-center has-large-font-size">Cover Image</p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:cover -->

<!-- wp:post-featured-image /-->

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

uninstall.php:35

• Indentation on this inline phpcs ignore comment uses spaces instead of the surrounding tab indentation, which can trip formatting/lint checks and makes the block inconsistent.

		// phpcs:ignore WordPressVIPMinimum.Functions.RestrictedFunctions.switch_to_blog_switch_to_blog -- The state doesn't matter during uninstall.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

[Kallyan01]

@justlevine, I've replaced our previous approach with the proxy attachment method you suggested.

I also tested the sample block of code you shared, but I wasn't able to reproduce the issue. Our current problem appears to be specific to media files. When I added the shared code to a post and searched for it, it appeared as expected on both the source and remote sites.