Prune CherryUSB stack and fix 64-bit pointer truncation#8
Open
rtech-technologies wants to merge 5 commits into
Open
Conversation
- Pruned external/CherryUSB to include only essential folders: common, core, class (msc, hid, cdc, hub), and port/ehci. - Fixed 64-bit pointer truncation in EHCI register macros in usb_ehci_reg.h. - Fixed 64-bit pointer alignment checks in usb_hc_ehci.c using uintptr_t. - Added 'Modified by Sovereign' headers to modified CherryUSB files. - Verified successful kernel build with zero warnings. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Aggressively pruned external/CherryUSB to match Sovereign RTC64 rules. - Kept only common/, core/, class/ (CDC, HID, HUB, MSC), and port/ehci/. - Removed all other vendor ports, demos, docs, tools, and osal stock files. - Fixed 64-bit pointer truncation in QH_HLP_* macros in usb_ehci_reg.h. - Fixed 64-bit pointer alignment checks in usb_hc_ehci.c using uintptr_t. - Updated .gitignore to allow tracking of the pruned CherryUSB source. - Verified successful kernel build with zero warnings and zero errors. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Restored all USB class and port drivers. - Kept documentation (docs/). - Removed demos (demo/), tools (tools/), and stock OSAL files. - Re-applied 64-bit pointer truncation fixes to EHCI driver. - Updated .gitignore to track the pruned CherryUSB source. - Verified successful kernel build. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Restored all USB class and port drivers to external/CherryUSB. - Kept documentation (docs/). - Removed demos (demo/), tools (tools/), and stock OSAL files. - Re-applied 64-bit pointer truncation fixes to EHCI driver (usb_ehci_reg.h, usb_hc_ehci.c). - Updated .gitignore to track the expanded but pruned CherryUSB source. - Verified successful kernel compilation and directory structure. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
- Expanded CherryUSB to include all class and port drivers. - Preserved documentation (docs/) while removing demos and tools. - Fixed 64-bit pointer truncation in EHCI driver for higher-half kernel. - Created comp.md to document the successful build with zero warnings. - Updated .gitignore to track the pruned CherryUSB source. Co-authored-by: rtech-technologies <254326487+rtech-technologies@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prunes the CherryUSB external dependency to include only the necessary core, common, class, and EHCI port files required for the Sovereign RTC64 kernel. It also fixes 64-bit pointer truncation issues in the EHCI driver by using uintptr_t for pointer-to-integer conversions and macros, ensuring compatibility with the higher-half kernel and resolving compiler warnings.
PR created automatically by Jules for task 9959398800727762945 started by @rtech-technologies