Fix ActivePage in viewPage function#47
Open
jluckyiv wants to merge 6 commits intortfeldman:masterfrom
jluckyiv:fix-active-navbarlinks
Open
Fix ActivePage in viewPage function#47jluckyiv wants to merge 6 commits intortfeldman:masterfrom jluckyiv:fix-active-navbarlinks
jluckyiv wants to merge 6 commits intortfeldman:masterfrom
jluckyiv:fix-active-navbarlinks
Conversation
Disable submit button, while making API request in 'create/edit article' form
Update the `viewPage` function's `case` statement to use the appropriate page, i.e., `Page.Settings`, `Page.Login`, `Page.Register` instead of `Page.Other` so that the `frame` function sends the appropriate `ActivePage` value to `Page.viewHeader`, `Page.navbarLink`, and `Page.isActive`.
That's because most of the code was formated with elm-format > 0.7.0, where the body of |
Author
|
Done. @SidneyNemzer thanks for the tip! |
rtfeldman
force-pushed
the
master
branch
8 times, most recently
from
19cab04 to
7a0ff12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
viewPagefunction'scasestatement to use the appropriatePage.ActivePage, i.e.,Page.Settings,Page.Login,Page.Registerinstead ofPage.Otherso that theframefunction sends the appropriatePage.ActivePagevalue toPage.viewHeader,Page.navbarLink, andPage.isActive.The only changes are on lines 117, 127, and 132.
elm-formatreformatted the entire file with extra whitespace.