Fix other isdigit() instances that are better as isdecimal().

Both raised exceptions, but the latter raises a
dns.exception.SyntaxError in cases where the old code raised
ValueError.

This change also fixes the tokenizer's get_int() method, which
did not work for bases bigger than 10.

Author: rthalley

dns/e164.py

@@ -44,7 +44,7 @@ def from_e164(
     :rtype: :py:class:`dns.name.Name`
     """
 
-    parts = [d for d in text if d.isdigit()]
+    parts = [d for d in text if d.isdecimal()]
     parts.reverse()
     return dns.name.from_text(".".join(parts), origin=origin)
 

dns/enum.py

@@ -50,7 +50,7 @@ def from_text(cls: type[TIntEnum], text: str) -> TIntEnum:
         if value:
             return value
         prefix = cls._prefix()
-        if text.startswith(prefix) and text[len(prefix) :].isdigit():
+        if text.startswith(prefix) and text[len(prefix) :].isdecimal():
             value = int(text[len(prefix) :])
             cls._check_value(value)
             return cls(value)

dns/flags.py

@@ -62,7 +62,7 @@ def _from_text(text: str, enum_class: Any) -> int:
     tokens = text.split()
     for t in tokens:
         token = t.upper()
-        if token.startswith("FLAG") and token[4:].isdigit():
+        if token.startswith("FLAG") and token[4:].isdecimal():
             # An unnamed flag, rendered by _to_text() as FLAGn (see below).
             flags |= 1 << int(token[4:])
         else:

dns/grange.py

@@ -49,7 +49,7 @@ def from_text(text: str) -> tuple[int, int, int]:
             stop = int(cur)
             cur = ""
             state = 2
-        elif c.isdigit():
+        elif c.isdecimal():
             cur += c
         else:
             raise dns.exception.SyntaxError(f"Could not parse {c}")

dns/inet.py

@@ -149,7 +149,7 @@ def low_level_address_tuple(high_tuple: tuple[str, int], af: int | None = None)
         # try to avoid getaddrinfo()
         addrpart = address[:i]
         scope = address[i + 1 :]
-        if scope.isdigit():
+        if scope.isdecimal():
             return (addrpart, port, 0, int(scope))
         try:
             return (addrpart, port, 0, socket.if_nametoindex(scope))

dns/name.py

@@ -1004,14 +1004,14 @@ def from_unicode(
         for c in text:
             if escaping:
                 if edigits == 0:
-                    if c.isdigit():
+                    if c.isdecimal():
                         total = int(c)
                         edigits += 1
                     else:
                         label += c
                         escaping = False
                 else:
-                    if not c.isdigit():
+                    if not c.isdecimal():
                         raise BadEscape
                     total *= 10
                     total += int(c)

dns/rdtypes/ANY/GPOS.py

@@ -36,9 +36,9 @@ def _validate_float_string(what):
         raise dns.exception.FormError
     if left == b"" and right == b"":
         raise dns.exception.FormError
-    if not left == b"" and not left.decode().isdigit():
+    if not left == b"" and not left.isdigit():
         raise dns.exception.FormError
-    if not right == b"" and not right.decode().isdigit():
+    if not right == b"" and not right.isdigit():
         raise dns.exception.FormError
 
 

dns/rdtypes/ANY/LOC.py

@@ -196,16 +196,16 @@ def from_text(
 
         latitude[0] = tok.get_int()
         t = tok.get_string()
-        if t.isdigit():
+        if t.isdecimal():
             latitude[1] = int(t)
             t = tok.get_string()
             if "." in t:
                 seconds, milliseconds = t.split(".")
-                if not seconds.isdigit():
+                if not seconds.isdecimal():
                     raise dns.exception.SyntaxError("bad latitude seconds value")
                 latitude[2] = int(seconds)
                 l = len(milliseconds)
-                if l == 0 or l > 3 or not milliseconds.isdigit():
+                if l == 0 or l > 3 or not milliseconds.isdecimal():
                     raise dns.exception.SyntaxError("bad latitude milliseconds value")
                 if l == 1:
                     m = 100
@@ -215,7 +215,7 @@ def from_text(
                     m = 1
                 latitude[3] = m * int(milliseconds)
                 t = tok.get_string()
-            elif t.isdigit():
+            elif t.isdecimal():
                 latitude[2] = int(t)
                 t = tok.get_string()
         if t == "S":
@@ -225,16 +225,16 @@ def from_text(
 
         longitude[0] = tok.get_int()
         t = tok.get_string()
-        if t.isdigit():
+        if t.isdecimal():
             longitude[1] = int(t)
             t = tok.get_string()
             if "." in t:
                 seconds, milliseconds = t.split(".")
-                if not seconds.isdigit():
+                if not seconds.isdecimal():
                     raise dns.exception.SyntaxError("bad longitude seconds value")
                 longitude[2] = int(seconds)
                 l = len(milliseconds)
-                if l == 0 or l > 3 or not milliseconds.isdigit():
+                if l == 0 or l > 3 or not milliseconds.isdecimal():
                     raise dns.exception.SyntaxError("bad longitude milliseconds value")
                 if l == 1:
                     m = 100
@@ -244,7 +244,7 @@ def from_text(
                     m = 1
                 longitude[3] = m * int(milliseconds)
                 t = tok.get_string()
-            elif t.isdigit():
+            elif t.isdecimal():
                 longitude[2] = int(t)
                 t = tok.get_string()
         if t == "W":

dns/rdtypes/IN/WKS.py

@@ -60,14 +60,14 @@ def from_text(
     ):
         address = tok.get_string()
         protocol = tok.get_string()
-        if protocol.isdigit():
+        if protocol.isdecimal():
             protocol = int(protocol)
         else:
             protocol = socket.getprotobyname(protocol)
         bitmap = bytearray()
         for token in tok.get_remaining():
             value = token.unescape().value
-            if value.isdigit():
+            if value.isdecimal():
                 serv = int(value)
             else:
                 if protocol != _proto_udp and protocol != _proto_tcp:

dns/rdtypes/rrsigbase.py

@@ -34,7 +34,7 @@ class BadSigTime(dns.exception.DNSException):
 
 
 def sigtime_to_posixtime(what):
-    if len(what) <= 10 and what.isdigit():
+    if len(what) <= 10 and what.isdecimal():
         return int(what)
     if len(what) != 14:
         raise BadSigTime