Skip to content

Commit 9247207

Browse files
authored
Merge pull request learningequality#5838 from AllanOXDi/deletedforreal
Fix Administration bug when deleted users are still listed in the users table.
2 parents f18cdf8 + ce61114 commit 9247207

4 files changed

Lines changed: 6 additions & 2 deletions

File tree

contentcuration/contentcuration/frontend/administration/composables/useTable.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,5 +115,6 @@ export function useTable({ fetchFunc, filterFetchQueryParams }) {
115115
return {
116116
pagination,
117117
loading,
118+
loadItems,
118119
};
119120
}

contentcuration/contentcuration/frontend/administration/pages/Users/UserItem.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@
113113
<UserActionsDropdown
114114
:userId="userId"
115115
flat
116+
@deleted="$emit('deleted')"
116117
/>
117118
</td>
118119
</tr>

contentcuration/contentcuration/frontend/administration/pages/Users/UserTable.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@
123123
<UserItem
124124
v-model="selected"
125125
:userId="item"
126+
@deleted="loadItems"
126127
/>
127128
</template>
128129
</VDataTable>
@@ -246,7 +247,7 @@
246247
return store.dispatch('userAdmin/loadUsers', fetchParams);
247248
}
248249
249-
const { pagination, loading } = useTable({
250+
const { pagination, loading, loadItems } = useTable({
250251
fetchFunc: fetchParams => loadUsers(fetchParams),
251252
filterFetchQueryParams,
252253
});
@@ -261,6 +262,7 @@
261262
clearSearch,
262263
pagination,
263264
loading,
265+
loadItems,
264266
filterFetchQueryParams,
265267
};
266268
},

contentcuration/contentcuration/viewsets/user.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ class AdminUserViewSet(
431431
"edit_count",
432432
"view_count",
433433
)
434-
queryset = User.objects.all()
434+
queryset = User.objects.filter(deleted=False)
435435

436436
def annotate_queryset(self, queryset):
437437
edit_channel_query = (

0 commit comments

Comments
 (0)