Skip to content

Commit c15fb32

Browse files
committed
Use KModal for summary dialog
1 parent c6c7b8a commit c15fb32

2 files changed

Lines changed: 18 additions & 35 deletions

File tree

contentcuration/contentcuration/frontend/channelEdit/pages/StagingTreePage/index.spec.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -382,12 +382,10 @@ describe('StagingTreePage', () => {
382382
expect(removeMultipleSpaces(text)).toBe('Total size: 8 MB (+ 8 MB)');
383383
});
384384

385-
it('summary details dialog is not visible by default', () => {
386-
expect(getSummaryDetailsDialog(wrapper).isVisible()).toBe(false);
387-
});
388-
389385
it('opens summary details dialog when view summary button is clicked', () => {
386+
expect(getSummaryDetailsDialog(wrapper).exists()).toBe(false);
390387
getDisplaySummaryDetailsDialogBtn(wrapper).trigger('click');
388+
391389
expect(getSummaryDetailsDialog(wrapper).isVisible()).toBe(true);
392390
});
393391

contentcuration/contentcuration/frontend/channelEdit/pages/StagingTreePage/index.vue

Lines changed: 16 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -170,38 +170,13 @@
170170
</VFlex>
171171

172172
<VFlex class="bottom-bar-btns">
173-
<VDialog
174-
v-model="displaySummaryDetailsDialog"
175-
width="500"
173+
<VBtn
174+
flat
175+
data-test="display-summary-details-dialog-btn"
176+
@click="displaySummaryDetailsDialog = true"
176177
>
177-
<template v-slot:activator="{ on }">
178-
<VBtn
179-
flat
180-
data-test="display-summary-details-dialog-btn"
181-
v-on="on"
182-
>
183-
{{ $tr('openSummaryDetailsDialogBtn') }}
184-
</VBtn>
185-
</template>
186-
187-
<VCard data-test="summary-details-dialog">
188-
<VCardTitle primary-title class="font-weight-bold title">
189-
{{ $tr('summaryDetailsDialogTitle') }}
190-
</VCardTitle>
191-
<VCardText>
192-
<DiffTable :stagingDiff="stagingDiff" @reload="reloadCurrentChannelStagingDiff" />
193-
</VCardText>
194-
<VCardActions>
195-
<VSpacer />
196-
<VBtn
197-
color="primary"
198-
@click="displaySummaryDetailsDialog = false"
199-
>
200-
{{ $tr('closeSummaryDetailsDialogBtn') }}
201-
</VBtn>
202-
</VCardActions>
203-
</VCard>
204-
</VDialog>
178+
{{ $tr('openSummaryDetailsDialogBtn') }}
179+
</VBtn>
205180

206181
<VDialog
207182
v-model="displayDeployDialog"
@@ -265,6 +240,16 @@
265240
</VFLex>
266241
</VLayout>
267242
</BottomBar>
243+
244+
<KModal
245+
v-if="displaySummaryDetailsDialog"
246+
data-test="summary-details-dialog"
247+
:title="$tr('summaryDetailsDialogTitle')"
248+
:cancelText="$tr('closeSummaryDetailsDialogBtn')"
249+
@cancel="displaySummaryDetailsDialog = false"
250+
>
251+
<DiffTable :stagingDiff="stagingDiff" @reload="reloadCurrentChannelStagingDiff" />
252+
</KModal>
268253
</template>
269254
</div>
270255

0 commit comments

Comments
 (0)